generic ieee80211_sta_commit()?

generic ieee80211_sta_commit()?

[Alina Friedrichsen]

Hello,

after a "ip link set wlan0 down" and than "ip link set wlan0 up" the wi=
fi connection don't come up again. If you do a "iwconfig wlan0 channel =
4" beaconing in IBSS doesn't work anymore.

My thought to fix this is to add a generic ieee80211_sta_commit() funct=
ion which is called after the most config changes (e.g. SSID, BSSID, ch=
annel, interface up, ...), so that a clean rejoin is done by the functi=
on and the driver hangs not in an undefined state. And I think it's mor=
e elegant, because ieee80211_sta_set_bssid() then doesn't need to call =
ieee80211_sta_set_ssid() anymore to do the rejoin.

What do you think about it? If agree I will implement it after Johannes=
 IBSS changes are applied to avoid confusion.

Regards
Alina

--=20
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL=20
f=FCr nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T4=
569a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: generic ieee80211_sta_commit()?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Hi,

On Sun, 2009-02-08 at 00:35 +0100, Alina Friedrichsen wrote:
> Hello,
> 
> after a "ip link set wlan0 down" and than "ip link set wlan0 up" the
> wifi connection don't come up again. If you do a "iwconfig wlan0
> channel 4" beaconing in IBSS doesn't work anymore.

What if you set the SSID again? I'd think that would help?

> My thought to fix this is to add a generic ieee80211_sta_commit()
> function which is called after the most config changes (e.g. SSID,
> BSSID, channel, interface up, ...), so that a clean rejoin is done by
> the function and the driver hangs not in an undefined state. And I
> think it's more elegant, because ieee80211_sta_set_bssid() then
> doesn't need to call ieee80211_sta_set_ssid() anymore to do the
> rejoin.

That could make sense, not exactly sure at this point. I'm also still
wondering about the other issue with turning _off_ IBSS, with essid off
or so, see my other mail.

> What do you think about it? If agree I will implement it after
> Johannes IBSS changes are applied to avoid confusion.

Sounds reasonable, if it fixes a bug. I'd have to see the patch, I
guess. I'd like to also do assoc/IBSS stuff in cfg80211 at some point
soonish.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: generic ieee80211_sta_commit()?

[Alina Friedrichsen]

Hello!

> What if you set the SSID again? I'd think that would help?

Yes it only works again if you do so.

> That could make sense, not exactly sure at this point. I'm also still
> wondering about the other issue with turning _off_ IBSS, with essid o=
ff
> or so, see my other mail.

What mail do you mean?

> Sounds reasonable, if it fixes a bug.

I think it's a clean-up, too.

> I'd have to see the patch, I
> guess. I'd like to also do assoc/IBSS stuff in cfg80211 at some point
> soonish.

How do you mean it?

Regards
Alina

--=20
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL=20
f=FCr nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T4=
569a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: generic ieee80211_sta_commit()?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 750 bytes --]

On Sun, 2009-02-08 at 18:45 +0100, Alina Friedrichsen wrote:

> > What if you set the SSID again? I'd think that would help?
> 
> Yes it only works again if you do so.

Ok.

> > That could make sense, not exactly sure at this point. I'm also still
> > wondering about the other issue with turning _off_ IBSS, with essid off
> > or so, see my other mail.
> 
> What mail do you mean?

Subject: turning off IBSS (with wext)

> > Sounds reasonable, if it fixes a bug.
> 
> I think it's a clean-up, too.
> 
> > I'd have to see the patch, I
> > guess. I'd like to also do assoc/IBSS stuff in cfg80211 at some point
> > soonish.
> 
> How do you mean it?

Well, I want to push configuration for bss/ibss into cfg80211.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: generic ieee80211_sta_commit()?

[Alina Friedrichsen]

Hello Johannes!

> Subject: turning off IBSS (with wext)

It looks to me that there and elsewhere is a need for more sanity check=
s.

> Well, I want to push configuration for bss/ibss into cfg80211.

ACK

Regards
Alina

--=20
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL=20
f=FCr nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T4=
569a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html