From: "Bob Copeland" <me@bobcopeland.com>
To: Russ Dill <russ.dill@gmail.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
Tulio Magno Quites Machado Filho <tuliom@gmail.com>
Subject: Re: ath5k LEDs on Acer Ferrari 5000 laptop
Date: Mon, 9 Feb 2009 11:50:22 -0500 [thread overview]
Message-ID: <20090209164501.M58498@bobcopeland.com> (raw)
In-Reply-To: <f9d2a5e10902090822i36989c8bl45c4a34c0cbb90b8@mail.gmail.com>
On Mon, 9 Feb 2009 09:22:16 -0700, Russ Dill wrote
> So no, the LED does not work with or without the emachines patch. It
> only works if I instead set sc->led_pin to 1 and sc->led_on to 1. I
> only mention the emachines patch because it tries to cover 100% of
> AMBIT systems, whereas my laptop wireless chipset identifies as AMBIT,
> but its LED is wired differently.
Right, ok, that is what I wanted to know. I guess we can just
differentiate based on sub-device ID.
I actually have some LED cleanup patches sitting around that need dusting
off, part of which is a sysfs file to set the led pin and polarity (I have
mixed feelings about the usefulness of that part, perhaps it is overkill).
Also todo is to make that device selection table-driven instead of
cascading ifs. I'll post that stuff this week.
As for the function of each LED -- correct, right now we just map everything
on to rx and tx; it's definitely not ideal.
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-02-09 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 6:09 ath5k LEDs on Acer Ferrari 5000 laptop Russ Dill
2009-02-09 15:14 ` Bob Copeland
2009-02-09 16:22 ` Russ Dill
2009-02-09 16:50 ` Bob Copeland [this message]
2009-02-09 16:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209164501.M58498@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=russ.dill@gmail.com \
--cc=tuliom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox