linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: orinoco: fix broken make allyesconfig due to multiple defs of michael_mic
@ 2009-02-13  7:21 Johannes Berg
  2009-02-13 13:17 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-02-13  7:21 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

I don't think the fix is correct:

-       priv->tx_tfm_mic = crypto_alloc_hash("michael_mic", 0, 0);
+       priv->tx_tfm_mic = crypto_alloc_hash("orinoco_mic", 0, 0);

that'll never find anything. Renaming the function name was a good plan,
but not changing the string here :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: orinoco: fix broken make allyesconfig due to multiple defs of michael_mic
  2009-02-13  7:21 orinoco: fix broken make allyesconfig due to multiple defs of michael_mic Johannes Berg
@ 2009-02-13 13:17 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2009-02-13 13:17 UTC (permalink / raw)
  To: Johannes Berg; +Cc: linux-wireless

On Fri, Feb 13, 2009 at 08:21:20AM +0100, Johannes Berg wrote:
> I don't think the fix is correct:
> 
> -       priv->tx_tfm_mic = crypto_alloc_hash("michael_mic", 0, 0);
> +       priv->tx_tfm_mic = crypto_alloc_hash("orinoco_mic", 0, 0);
> 
> that'll never find anything. Renaming the function name was a good plan,
> but not changing the string here :)

Good point... :-)  I'll fix it up some more...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-13 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-13  7:21 orinoco: fix broken make allyesconfig due to multiple defs of michael_mic Johannes Berg
2009-02-13 13:17 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).