[PATCH] Fix transmit LED on Acer Aspire One

[PATCH] Fix transmit LED on Acer Aspire One

[Peter Chubb]

I've seen a whole heap of fixes for the Aspire One's wireless LED on
the web, but nothing in the kernel yet.

Here's my take on it.  My only worry is other machines with the same card.

Signed-off-by: Peter Chubb <peterc@gelato.unsw.edu.au>

---
---
 drivers/net/wireless/ath5k/base.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux-2.6/drivers/net/wireless/ath5k/base.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/ath5k/base.c	2009-02-18 10:26:48.000000000 +1100
+++ linux-2.6/drivers/net/wireless/ath5k/base.c	2009-02-18 14:06:06.000000000 +1100
@@ -2619,6 +2619,12 @@
 		sc->led_pin = 1;
 		sc->led_on = 1;  /* active high */
 	}
+	/* Enable softled on Acer Aspire One */
+	else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
+		__set_bit(ATH_STAT_LEDSOFT, sc->status);
+		sc->led_pin = 3;
+		sc->led_on = 0;
+	}
 	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
 		goto out;
 

--
Dr Peter Chubb  http://www.gelato.unsw.edu.au  peterc AT gelato.unsw.edu.au
http://www.ertos.nicta.com.au           ERTOS within National ICT Australia
A university is a non-profit organisation only in the sense that it
spends everything it gets  ... Luca Turin.

Re: [PATCH] Fix transmit LED on Acer Aspire One

[John W. Linville]

On Wed, Feb 18, 2009 at 02:07:05PM +1100, Peter Chubb wrote:
> 
> I've seen a whole heap of fixes for the Aspire One's wireless LED on
> the web, but nothing in the kernel yet.
> 
> Here's my take on it.  My only worry is other machines with the same card.
> 
> Signed-off-by: Peter Chubb <peterc@gelato.unsw.edu.au>
> 
> ---
> ---
>  drivers/net/wireless/ath5k/base.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> Index: linux-2.6/drivers/net/wireless/ath5k/base.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/wireless/ath5k/base.c	2009-02-18 10:26:48.000000000 +1100
> +++ linux-2.6/drivers/net/wireless/ath5k/base.c	2009-02-18 14:06:06.000000000 +1100
> @@ -2619,6 +2619,12 @@
>  		sc->led_pin = 1;
>  		sc->led_on = 1;  /* active high */
>  	}
> +	/* Enable softled on Acer Aspire One */
> +	else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
> +		__set_bit(ATH_STAT_LEDSOFT, sc->status);
> +		sc->led_pin = 3;
> +		sc->led_on = 0;
> +	}
>  	if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
>  		goto out;

Any comment on this from the ath5k guys?  That 0x105b subvendor ID
would seem to correspond to "Foxconn International, Inc.", which
doesn't sound much like "Acer"...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [ath5k-devel] [PATCH] Fix transmit LED on Acer Aspire One

[Bob Copeland]

On Mon, Feb 23, 2009 at 2:37 PM, John W. Linville
<linville@tuxdriver.com> wrote:
> On Wed, Feb 18, 2009 at 02:07:05PM +1100, Peter Chubb wrote:
>> +     /* Enable softled on Acer Aspire One */
>> +     else if (pdev->subsystem_vendor == 0x105b && pdev->subsystem_device == 0xe008) {
>> +             __set_bit(ATH_STAT_LEDSOFT, sc->status);
>> +             sc->led_pin = 3;
>> +             sc->led_on = 0;
>> +     }
>>       if (!test_bit(ATH_STAT_LEDSOFT, sc->status))
>>               goto out;
>
> Any comment on this from the ath5k guys?  That 0x105b subvendor ID
> would seem to correspond to "Foxconn International, Inc.", which
> doesn't sound much like "Acer"...

It's already in wireless-testing with similar values.

Not quite apropos to this patch, someone with the ambit chipset said
the values didn't match up with his laptop, so we do need to add a
subsystem_device test I think, but it should have a #define in pci.h.
In any case there's usually no harm in enabling the wrong gpio pin,
unless rfkill happens to sit there.

-- 
Bob Copeland %% www.bobcopeland.com