From: Michael Buesch <mb@bu3sch.de>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Add module parameter to disable hardware crypto
Date: Tue, 24 Feb 2009 17:15:49 +0100 [thread overview]
Message-ID: <200902241715.49803.mb@bu3sch.de> (raw)
In-Reply-To: <20090224114201.GB21933@jm.kir.nu>
On Tuesday 24 February 2009 12:42:01 Jouni Malinen wrote:
> #define CHAN2G(_freq, _idx) { \
> @@ -1587,7 +1591,7 @@ int ath_attach(u16 devid, struct ath_sof
> IEEE80211_HW_SUPPORTS_PS |
> IEEE80211_HW_PS_NULLFUNC_STACK;
>
> - if (AR_SREV_9160_10_OR_LATER(sc->sc_ah))
> + if (AR_SREV_9160_10_OR_LATER(sc->sc_ah) || modparam_nohwcrypt)
> hw->flags |= IEEE80211_HW_MFP_CAPABLE;
Are you sure this is correct?
The hardware capability doesn't magically change by switching a modparam.
Either the HW is MFP capable or it isn't.
If hwcrypto is disabled (set_key returns error), mac80211 should be smart
enough to do crypto (including MFP) in software anyway.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-02-24 16:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 11:42 [PATCH] ath9k: Add module parameter to disable hardware crypto Jouni Malinen
2009-02-24 13:49 ` Johannes Berg
2009-02-24 14:06 ` Jouni Malinen
2009-02-24 14:23 ` Johannes Berg
2009-02-24 14:24 ` pat-lkml
2009-02-24 15:07 ` Jouni Malinen
2009-02-24 15:32 ` pat-lkml
2009-02-24 20:07 ` pat-lkml
2009-02-24 22:45 ` pat-lkml
2009-02-25 18:19 ` ath9k and TKIP hw crypto in AP mode Jouni Malinen
2009-02-25 23:46 ` pat-lkml
2009-02-26 0:10 ` pat-lkml
2009-02-26 9:10 ` Jouni Malinen
2009-02-24 16:15 ` Michael Buesch [this message]
2009-02-24 17:07 ` [PATCH] ath9k: Add module parameter to disable hardware crypto Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902241715.49803.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).