* [PATCH] cfg80211: unregister ml groups on failure
@ 2009-02-25 1:14 Luis R. Rodriguez
2009-02-25 1:44 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-02-25 1:14 UTC (permalink / raw)
To: johannes, johannes, linville; +Cc: Luis R. Rodriguez, linux-wireless
We were not doing so before.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
net/wireless/nl80211.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 04ef828..e5d9060 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -2806,9 +2806,12 @@ int nl80211_init(void)
err = genl_register_mc_group(&nl80211_fam, &nl80211_scan_mcgrp);
if (err)
- goto err_out;
+ goto err_out_scan_mc;
return 0;
+
+ err_out_scan_mc:
+ genl_unregister_mc_group(&nl80211_fam, &nl80211_config_mcgrp);
err_out:
genl_unregister_family(&nl80211_fam);
return err;
--
1.6.1.2.253.ga34a
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cfg80211: unregister ml groups on failure
2009-02-25 1:14 [PATCH] cfg80211: unregister ml groups on failure Luis R. Rodriguez
@ 2009-02-25 1:44 ` Johannes Berg
2009-02-25 1:53 ` Luis R. Rodriguez
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2009-02-25 1:44 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
On Tue, 2009-02-24 at 17:14 -0800, Luis R. Rodriguez wrote:
> We were not doing so before.
and we don't need to, they get removed with the family automatically.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cfg80211: unregister ml groups on failure
2009-02-25 1:44 ` Johannes Berg
@ 2009-02-25 1:53 ` Luis R. Rodriguez
0 siblings, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-02-25 1:53 UTC (permalink / raw)
To: Johannes Berg
Cc: Luis Rodriguez, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
On Tue, Feb 24, 2009 at 05:44:42PM -0800, Johannes Berg wrote:
> On Tue, 2009-02-24 at 17:14 -0800, Luis R. Rodriguez wrote:
> > We were not doing so before.
>
> and we don't need to, they get removed with the family automatically.
Oh, nice, I figured that was a chance but thought it would have been too
good to be true.
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-25 1:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 1:14 [PATCH] cfg80211: unregister ml groups on failure Luis R. Rodriguez
2009-02-25 1:44 ` Johannes Berg
2009-02-25 1:53 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).