Re: [PATCH v2] mac80211: Call commit() on channel setting

["Alina Friedrichsen" <x-alina@gmx.net>]

Hello Michael!

> Could you explain what commit is supposed to to after the channel swi=
tch?
> To me it's not clear what the difference in functionality is.
> What do you expect to happen on the commit call after the channel cha=
nge.

I think after all changes which affect the selected network a rejoin sh=
ould be done.

=46or example you have at channel 4 a AP with the SSID "test" und at ch=
annel 11 an other AP with the same SSID, too.

If you now first say set_ssid("test") and then set_channel(11), we firs=
t join the network at channel 4 and then we switch the hardware low-lev=
el to channel 11. So we hang now in channel 4 with the BSSID of the net=
work in channel 4 and nothing works anymore.

I think the order of the commands should not affect the result on the e=
nd and the driver should never hang in an broken/undefined state if it =
can be recovered.

Regards
Alina

--=20
Computer Bild Tarifsieger! GMX FreeDSL - Telefonanschluss + DSL
f=FCr nur 17,95 =BF/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T45=
69a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html