linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alina Friedrichsen" <x-alina@gmx.net>
To: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	johannes@sipsolutions.net
Subject: [PATCH v3] mac80211: Call commit() on channel setting
Date: Fri, 27 Feb 2009 19:25:20 +0100	[thread overview]
Message-ID: <20090227182520.97260@gmx.net> (raw)
In-Reply-To: <20090227171618.254890@gmx.net>

This calls commit() on all logical interfaces of a physical interface, =
if the channel of it is changed. Before it works as it should, I must f=
ix the joining process of STA and IBSS a little, which I will make tomo=
rrow.

This version call it only in the wireless extensions, because the handl=
ing in nl80211 must discussed more, but I think in the case of wext it =
is the right way.

Signed-off-by: Alina Friedrichsen <x-alina@gmx.net>
---
diff --git a/net/mac80211/wext.c b/net/mac80211/wext.c
index 1ac0516..dce1618 100644
--- a/net/mac80211/wext.c
+++ b/net/mac80211/wext.c
@@ -157,7 +157,10 @@ static int ieee80211_ioctl_siwfreq(struct net_devi=
ce *dev,
 				   struct iw_request_info *info,
 				   struct iw_freq *freq, char *extra)
 {
+	struct ieee80211_local *local =3D wdev_priv(dev->ieee80211_ptr);
 	struct ieee80211_sub_if_data *sdata =3D IEEE80211_DEV_TO_SUB_IF(dev);
+	struct ieee80211_sub_if_data *nsdata;
+	int ret;
=20
 	if (sdata->vif.type =3D=3D NL80211_IFTYPE_ADHOC)
 		sdata->u.ibss.flags &=3D ~IEEE80211_IBSS_AUTO_CHANNEL_SEL;
@@ -173,19 +176,25 @@ static int ieee80211_ioctl_siwfreq(struct net_dev=
ice *dev,
 			else if (sdata->vif.type =3D=3D NL80211_IFTYPE_STATION)
 				sdata->u.mgd.flags |=3D
 					IEEE80211_STA_AUTO_CHANNEL_SEL;
-			return 0;
+			ret =3D 0;
 		} else
-			return ieee80211_set_freq(sdata,
+			ret =3D ieee80211_set_freq(sdata,
 				ieee80211_channel_to_frequency(freq->m));
 	} else {
 		int i, div =3D 1000000;
 		for (i =3D 0; i < freq->e; i++)
 			div /=3D 10;
 		if (div > 0)
-			return ieee80211_set_freq(sdata, freq->m / div);
+			ret =3D ieee80211_set_freq(sdata, freq->m / div);
 		else
-			return -EINVAL;
+			ret =3D -EINVAL;
 	}
+
+	list_for_each_entry(nsdata, &local->interfaces, list) {
+		ieee80211_commit(nsdata);
+	}
+
+	return ret;
 }
=20
=20

--=20
Psssst! Schon vom neuen GMX MultiMessenger geh=F6rt? Der kann`s mit all=
en: http://www.gmx.net/de/go/multimessenger01
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-02-27 18:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26 23:43 [PATCH v2] mac80211: Call commit() on channel setting Alina Friedrichsen
2009-02-27 14:03 ` Michael Buesch
2009-02-27 15:35   ` Alina Friedrichsen
2009-02-27 15:39     ` Alina Friedrichsen
     [not found]   ` <20090227153418.254900@gmx.net>
2009-02-27 16:14     ` Michael Buesch
2009-02-27 17:16       ` Alina Friedrichsen
2009-02-27 18:25         ` Alina Friedrichsen [this message]
2009-02-27 16:20 ` Johannes Berg
2009-02-27 21:26   ` Alina Friedrichsen
2009-02-27 21:35     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090227182520.97260@gmx.net \
    --to=x-alina@gmx.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).