From: "Alina Friedrichsen" <x-alina@gmx.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Replacement for: Implement commit in wireless extensions
Date: Fri, 27 Feb 2009 22:43:17 +0100 [thread overview]
Message-ID: <20090227214317.254870@gmx.net> (raw)
In-Reply-To: <1235768725.7426.83.camel@johannes.local>
Hello Johannes!
> I don't really see a need for that, it's only called in what, two
> places? And it makes things interdependent.
One centralized function is in
every case easier to maintain.
=46or example if you add mesh mode to it.
> At _least_ put it into a
> more appropriate file like wext.c
This function is config interface independent,
so wext.c is not the right place for it.
> and open-code it in cfg.c
This would be a better place for it
if it should be added to
mac80211_config_ops. If not I think
main.c is the best place for it.
Regards
Alina
--=20
Computer Bild Tarifsieger! GMX FreeDSL - Telefonanschluss + DSL
f=FCr nur 17,95 =BF/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T45=
69a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-02-27 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 18:43 [PATCH] mac80211: Replacement for: Implement commit in wireless extensions Alina Friedrichsen
2009-02-27 21:05 ` Johannes Berg
2009-02-27 21:43 ` Alina Friedrichsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090227214317.254870@gmx.net \
--to=x-alina@gmx.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).