From: Jouni Malinen <j@w1.fi>
To: Bob Copeland <me@bobcopeland.com>
Cc: Jouni Malinen <jouni.malinen@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Remove unused key xoring
Date: Mon, 2 Mar 2009 17:58:47 +0200 [thread overview]
Message-ID: <20090302155847.GA4891@jm.kir.nu> (raw)
In-Reply-To: <b6c5339f0903020720x3b2b8ef8ldf726d99c32a5202@mail.gmail.com>
On Mon, Mar 02, 2009 at 10:20:07AM -0500, Bob Copeland wrote:
> > - =C2=A0 =C2=A0 =C2=A0 key1 =3D (get_unaligned_le16(k->kv_val + 4) =
^ xorMask) & 0xffff;
> > - =C2=A0 =C2=A0 =C2=A0 key3 =3D (get_unaligned_le16(k->kv_val + 10)=
^ xorMask) & 0xffff;
> > + =C2=A0 =C2=A0 =C2=A0 key1 =3D get_unaligned_le16(k->kv_val + 4);
> > + =C2=A0 =C2=A0 =C2=A0 key3 =3D get_unaligned_le16(k->kv_val + 10) =
& 0xffff;
> key1 lost the mask but key3 kept it?
Heh.. Interesting editing bug that probably happened when I cleaned up
some of my pending patches. I don't think the '& 0xffff' part is really
needed here in either case.
=20
--=20
Jouni Malinen PGP id EFC895F=
A
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-02 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 13:07 [PATCH] ath9k: Remove unused key xoring Jouni Malinen
2009-03-02 15:20 ` Bob Copeland
2009-03-02 15:58 ` Jouni Malinen [this message]
2009-03-02 16:15 ` [PATCH v2] " Jouni Malinen
2009-03-03 0:57 ` [PATCH] " Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090302155847.GA4891@jm.kir.nu \
--to=j@w1.fi \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).