From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Mike Cui <cuicui@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: Bug in iw prevents setting the "cook" monitor flag
Date: Wed, 4 Mar 2009 09:14:02 -0500 [thread overview]
Message-ID: <20090304141402.GB7965@tuxdriver.com> (raw)
In-Reply-To: <87tz69six4.fsf@litku.valot.fi>
On Wed, Mar 04, 2009 at 12:04:39PM +0200, Kalle Valo wrote:
> "John W. Linville" <linville@tuxdriver.com> writes:
>
> > On Mon, Mar 02, 2009 at 03:16:14PM -0800, Mike Cui wrote:
> >> There is an off by one error in interface.c of iw that prevents
> >> passing of the cook flag when creating a monitor interface. The fix is
> >> simple:
> >>
> >>
> >> --- a/interface.c 2009-03-02 15:11:58.748078548 -0800
> >> +++ b/interface.c 2009-03-02 15:12:14.695203787 -0800
>
> [...]
>
> > FWIW, I think I like "x <= Y" instead of "x < Y + 1".
>
> I agree.
>
> > Also, please make sure you are following the guidelines explained here:
> >
> > http://linux.yyz.us/patch-format.html
> >
> > In particular, I need a Signed-off-by line from you.
>
> But this is for iw, not for wireless-testing. Or did I miss something?
Ah, you're right... :-) Then I'll let Johannes worry about that.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-03-04 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 23:16 Bug in iw prevents setting the "cook" monitor flag Mike Cui
2009-03-03 14:52 ` John W. Linville
2009-03-04 10:04 ` Kalle Valo
2009-03-04 14:14 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304141402.GB7965@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=cuicui@gmail.com \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).