* [PATCH 5/7] p54: fix iwconfig txpower off
@ 2009-03-05 20:31 Christian Lamparter
2009-03-14 6:53 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Christian Lamparter @ 2009-03-05 20:31 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville
Disabling the receiver logic with P54_FILTER_TYPE_RX_DISABLED is not
supported by all firmwares. However we have an alternative: hibernation.
And the only side effect - so far - is a bit less power consumption. WIN!
Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff -Nurp a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
--- a/drivers/net/wireless/p54/p54common.c 2009-03-05 15:11:07.000000000 +0100
+++ b/drivers/net/wireless/p54/p54common.c 2009-03-05 15:42:57.000000000 +0100
@@ -1674,7 +1674,7 @@ static int p54_setup_mac(struct ieee8021
mode = P54_FILTER_TYPE_PROMISCUOUS;
break;
default:
- mode = P54_FILTER_TYPE_NONE;
+ mode = P54_FILTER_TYPE_HIBERNATE;
break;
}
@@ -1687,7 +1687,7 @@ static int p54_setup_mac(struct ieee8021
(mode != P54_FILTER_TYPE_PROMISCUOUS))
mode |= P54_FILTER_TYPE_TRANSPARENT;
} else
- mode = P54_FILTER_TYPE_RX_DISABLED;
+ mode = P54_FILTER_TYPE_HIBERNATE;
setup->mac_mode = cpu_to_le16(mode);
memcpy(setup->mac_addr, priv->mac_addr, ETH_ALEN);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 5/7] p54: fix iwconfig txpower off
2009-03-05 20:31 [PATCH 5/7] p54: fix iwconfig txpower off Christian Lamparter
@ 2009-03-14 6:53 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2009-03-14 6:53 UTC (permalink / raw)
To: Christian Lamparter; +Cc: linux-wireless, John W. Linville
Christian Lamparter <chunkeey@web.de> writes:
> Disabling the receiver logic with P54_FILTER_TYPE_RX_DISABLED is not
> supported by all firmwares. However we have an alternative: hibernation.
> And the only side effect - so far - is a bit less power consumption. WIN!
Some stlc45xx firmware versions had problems in waking up from
hibernation, but I think they were fixed at some point. Just a heads
up.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-14 6:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-05 20:31 [PATCH 5/7] p54: fix iwconfig txpower off Christian Lamparter
2009-03-14 6:53 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).