From: Bob Copeland <me@bobcopeland.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: Re: [PATCH 2/2] ath5k: don't change mac in eeprom_read_mac on error
Date: Sat, 7 Mar 2009 07:34:38 -0500 [thread overview]
Message-ID: <20090307123438.GA13756@hash.localnet> (raw)
In-Reply-To: <1236418002-2189-2-git-send-email-jirislaby@gmail.com>
On Sat, Mar 07, 2009 at 10:26:42AM +0100, Jiri Slaby wrote:
> Do not touch mac parameter passed to ath5k_eeprom_read_mac unless
> we are sure we have correct address. I.e. when returning error, do
> not change it.
>
> While at it, use '= {}' compiler trick for memsetting mac_d.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Nick Kossifidis <jirislaby@gmail.com>
Wrong email address for Nick :) Otherwise,
Acked-by: Bob Copeland <me@bobcopeland.com>
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-03-07 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 9:26 [PATCH 1/2] ath5k: constify stuff Jiri Slaby
2009-03-07 9:26 ` [PATCH 2/2] ath5k: don't change mac in eeprom_read_mac on error Jiri Slaby
2009-03-07 12:06 ` [ath5k-devel] " Nick Kossifidis
2009-03-07 12:34 ` Bob Copeland [this message]
2009-03-07 12:03 ` [PATCH 1/2] ath5k: constify stuff Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090307123438.GA13756@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).