From: "John W. Linville" <linville@tuxdriver.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: 2.6.29-rc "TKIP: replay detected" regression
Date: Wed, 11 Mar 2009 11:11:02 -0400 [thread overview]
Message-ID: <20090311151102.GC8761@tuxdriver.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903111114510.22922@blonde.anvils>
On Wed, Mar 11, 2009 at 12:07:54PM +0000, Hugh Dickins wrote:
> Prior to 2.6.29-rc1's 274bfb8dc5ffa16cb073801bebe76ab7f4e2e73d
> "lib80211: absorb crypto bits from net/ieee80211", the TKIP and CCMP
> "replay detected" messages were subject to the IEEE80211_DEBUG_DROP()
> macro, neither I nor my distro had CONFIG_IEEE80211_DEBUG set, I never
> glimpsed such messages, and ThinkPad T43p ipw2200 wireless worked fine.
>
> - if (ieee80211_ratelimit_debug(IEEE80211_DL_DROP)) {
> - IEEE80211_DEBUG_DROP("TKIP: replay detected: STA=%pM"
> + if (net_ratelimit()) {
> + printk(KERN_DEBUG "TKIP: replay detected: STA=%pM"
Hugh, this is my mess -- sorry! I'll follow-up with a patch.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-03-11 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 12:07 2.6.29-rc "TKIP: replay detected" regression Hugh Dickins
2009-03-11 15:11 ` John W. Linville [this message]
2009-03-11 15:12 ` [PATCH] lib80211: silence excessive crypto debugging messages John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090311151102.GC8761@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).