Re: [PATCH v5 1/4] ath9k: implement IO serialization

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Wed, Mar 11, 2009 at 02:10:11AM -0700, Johannes Berg wrote:
> On Tue, 2009-03-10 at 22:52 -0400, Luis R. Rodriguez wrote:
> 
> > +	if (ah->config.serialize_regmode == SER_REG_MODE_ON) {
> > +		unsigned long flags;
> > +		spin_lock_irqsave(&ah->ah_sc->sc_serial_rw, flags);
> > +		iowrite32(val, ah->ah_sc->mem + reg_offset);
> > +		spin_unlock_irqrestore(&ah->ah_sc->sc_serial_rw, flags);
> > +	} else
> > +		iowrite32(val, ah->ah_sc->mem + reg_offset);
> 
> This is utterly insane. Just make it _always_ do the spinlock, and get
> rid of the hotplug notifier and all that crap.

That is certainly an option as well but we would obviously be incurring
the lock on all reads/writes regardless of what bus you use which is
not necessary. We'll review this and determine whether its worth it.

  Luis