From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: remove ieee80211_num_regular_queues
Date: Thu, 12 Mar 2009 23:44:03 +0100 [thread overview]
Message-ID: <200903122344.04238.mb@bu3sch.de> (raw)
In-Reply-To: <1236852956.4175.19.camel@johannes.local>
On Thursday 12 March 2009 11:15:56 Johannes Berg wrote:
> /* receiver and we are QoS enabled, use a QoS type frame */
> - if (sta_flags & WLAN_STA_WME &&
> - ieee80211_num_regular_queues(&local->hw) >= 4) {
> + if (sta_flags & WLAN_STA_WME && local->hw.queues >= 4) {
Could we add a few parenthesis while we're at it?
The code is correct, but it took me some time to realize that. ;)
--
Greetings, Michael.
next prev parent reply other threads:[~2009-03-12 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 10:15 [PATCH] mac80211: remove ieee80211_num_regular_queues Johannes Berg
2009-03-12 22:44 ` Michael Buesch [this message]
2009-03-12 22:49 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903122344.04238.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).