* [PATCH 1/3] ath5k: Choose the right initvals for RF2425
@ 2009-03-10 10:29 Nick Kossifidis
0 siblings, 0 replies; 3+ messages in thread
From: Nick Kossifidis @ 2009-03-10 10:29 UTC (permalink / raw)
To: ath5k-devel, linux-wireless, linville; +Cc: jirislaby, mcgrof, me, nbd
* Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413
Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
---
drivers/net/wireless/ath5k/initvals.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath5k/initvals.c b/drivers/net/wireless/ath5k/initvals.c
index 4488643..61fb621 100644
--- a/drivers/net/wireless/ath5k/initvals.c
+++ b/drivers/net/wireless/ath5k/initvals.c
@@ -1510,8 +1510,8 @@ int ath5k_hw_write_initvals(struct ath5k_hw *ah, u8 mode, bool change_channel)
rf2425_ini_mode_end, mode);
ath5k_hw_ini_registers(ah,
- ARRAY_SIZE(rf2413_ini_common_end),
- rf2413_ini_common_end, change_channel);
+ ARRAY_SIZE(rf2425_ini_common_end),
+ rf2425_ini_common_end, change_channel);
ath5k_hw_ini_registers(ah,
ARRAY_SIZE(rf5112_ini_bbgain),
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/3] ath5k: Choose the right initvals for RF2425
@ 2009-03-15 20:13 Nick Kossifidis
2009-03-16 2:28 ` Bob Copeland
0 siblings, 1 reply; 3+ messages in thread
From: Nick Kossifidis @ 2009-03-15 20:13 UTC (permalink / raw)
To: ath5k-devel, linux-wireless, linville; +Cc: jirislaby, mcgrof, me, nbd
* Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413
Note: This also fixes incorect pd gain overlap since RF2425 has different pd gain overlap from RF2413
Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
---
drivers/net/wireless/ath5k/initvals.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath5k/initvals.c b/drivers/net/wireless/ath5k/initvals.c
index 4488643..61fb621 100644
--- a/drivers/net/wireless/ath5k/initvals.c
+++ b/drivers/net/wireless/ath5k/initvals.c
@@ -1510,8 +1510,8 @@ int ath5k_hw_write_initvals(struct ath5k_hw *ah, u8 mode, bool change_channel)
rf2425_ini_mode_end, mode);
ath5k_hw_ini_registers(ah,
- ARRAY_SIZE(rf2413_ini_common_end),
- rf2413_ini_common_end, change_channel);
+ ARRAY_SIZE(rf2425_ini_common_end),
+ rf2425_ini_common_end, change_channel);
ath5k_hw_ini_registers(ah,
ARRAY_SIZE(rf5112_ini_bbgain),
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] ath5k: Choose the right initvals for RF2425
2009-03-15 20:13 [PATCH 1/3] ath5k: Choose the right initvals for RF2425 Nick Kossifidis
@ 2009-03-16 2:28 ` Bob Copeland
0 siblings, 0 replies; 3+ messages in thread
From: Bob Copeland @ 2009-03-16 2:28 UTC (permalink / raw)
To: ath5k-devel, linux-wireless, linville, jirislaby, mcgrof, nbd
On Sun, Mar 15, 2009 at 10:13:39PM +0200, Nick Kossifidis wrote:
> * Fix a typo in initvals.c so that we use the RF2425 array for RF2425 and not RF2413
>
> Note: This also fixes incorect pd gain overlap since RF2425 has different pd gain overlap from RF2413
>
> Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
Nice work, series:
Acked-by: Bob Copeland <me@bobcopeland.com>
If you do a follow-up cleanup patch, one quick thought I had is that
ee_pwr_cal_[abg] could be an array indexed by mode which might save a
few switch statements - I didn't look at it that hard though.
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-16 2:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-15 20:13 [PATCH 1/3] ath5k: Choose the right initvals for RF2425 Nick Kossifidis
2009-03-16 2:28 ` Bob Copeland
-- strict thread matches above, loose matches on Subject: below --
2009-03-10 10:29 Nick Kossifidis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).