Re: [PATCH v2] Fix SLAB corruption during rmmod

["John W. Linville" <linville@tuxdriver.com>]

On Mon, Mar 16, 2009 at 08:24:27PM +0100, Ivo van Doorn wrote:
> At rmmod stage, the code path is the following one :
>=20
> rt2x00lib_remove_dev
> =A0 -> =A0rt2x00lib_uninitialize()
> =A0 =A0 =A0 =A0 -> rt2x00rfkill_unregister()
> =A0 =A0 =A0 =A0 =A0 =A0 =A0-> rfkill_unregister()
> =A0 =A0 =A0 =A0 -> rt2x00rfkill_free()
> =A0 =A0 =A0 =A0 =A0 =A0 =A0-> rfkill_free()
>=20
> The problem is that rfkill_free should not be called after rfkill_reg=
ister
> otherwise put_device(&rfkill->dev) will be called 2 times. This patch
> fixes this by only calling rt2x00rfkill_free() when rt2x00rfkill_regi=
ster()
> hasn't been called or has failed.
>=20
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> Tested-by: Arnaud Patard <apatard@mandriva.com>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
>=20
> ---
> John, this patch is for 2.6.29 and only 2.6.29 since rfkill support i=
tself
> was removed from later versions (replaced by input_polldev).
> The patch is quite big to be merged in a late state of the release cy=
cle,
> but since the SLAB corruption is a serious problem, I hope this can g=
et in regardless.

Could you send me a version of this that applies on top of
wireless-testing?

Also, is there a bug report somewhere that describes this issue
this addresses?

Thanks,

John
--=20
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html