From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Antonio Marques <froz@icix.org>,
Andrey Yurovsky <andrey@cozybit.com>,
linux-wireless@vger.kernel.org
Subject: Re: rt2x00 mesh support
Date: Wed, 18 Mar 2009 00:01:07 +0100 [thread overview]
Message-ID: <200903180001.07723.IvDoorn@gmail.com> (raw)
In-Reply-To: <1237329348.5100.8.camel@johannes.local>
On Tuesday 17 March 2009, Johannes Berg wrote:
> On Tue, 2009-03-17 at 23:04 +0100, Ivo van Doorn wrote:
>
> > I think I found something interesting in the log from Antonio which does
> > suggest a mac80211 bug:
> >
> >
> > > [108565.280398] phy3 -> rt73usb_config_intf: Error - TXRX_CSR9 WRITE: 0x000d0000, READ: 0x000d0000
> > > [108565.385291] phy3 -> rt73usb_write_beacon: Error - TXRX_CSR9 WRITE: 0x00040000, READ: 0x00040000
> > > [108565.492687] phy3 -> rt73usb_kick_tx_queue: Error - TXRX_CSR9 WRITE: 0x001d0000, READ: 0x001d0000
> >
> > These 3 commands mean that mac80211 has send the beacon data.
> >
> > > [108565.603206] phy3 -> rt73usb_init_registers: Error - TXRX_CSR9 WRITE: 0x00000000, READ: 0x00000000
> >
> > This command means that mac80211 uses the start() callback function. This triggers rt2x00 to initialize
> > the registers which resets the beacon generation.
>
> Strange, that doesn't seem right. If you look at net/mac80211/iface.c,
> you'll see it call ->start(), then ->add_interface(), and later
> ieee80211_start_mesh(), which calls _if_config() and sets
> beacon/beacon_enabled.
ok, I gone through the rt2x00 code a couple of times now to see how this bug can be triggered by rt2x00,
But the only other scenario I could find, is when the open() callback for the netdevice structure doesn't end
with a call to the config() callback function. But as far as I see it that is happening correctly.
Ivo
next prev parent reply other threads:[~2009-03-17 23:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 18:58 rt2x00 mesh support Antonio Marques
2009-01-23 19:02 ` Andrey Yurovsky
2009-01-24 11:40 ` António Marques
2009-03-15 11:54 ` Antonio Marques
2009-03-15 13:45 ` Ivo van Doorn
2009-03-16 1:58 ` Pat Erley
2009-03-16 13:29 ` Antonio Marques
2009-03-16 13:22 ` António Marques
2009-03-16 14:58 ` Ivo van Doorn
2009-03-16 19:12 ` Antonio Marques
2009-03-17 9:31 ` Ivo van Doorn
2009-03-17 14:11 ` Johannes Berg
2009-03-17 20:10 ` Johannes Berg
2009-03-17 21:50 ` Ivo van Doorn
2009-03-17 21:53 ` Johannes Berg
2009-03-17 22:04 ` Ivo van Doorn
2009-03-17 22:35 ` Johannes Berg
2009-03-17 23:01 ` Ivo van Doorn [this message]
2009-03-17 23:04 ` Johannes Berg
2009-03-18 10:02 ` Ivo van Doorn
2009-03-18 12:26 ` Antonio Marques
2009-03-18 12:48 ` Ivo van Doorn
2009-03-18 13:12 ` Johannes Berg
2009-03-18 13:31 ` Ivo van Doorn
2009-03-18 13:36 ` Johannes Berg
2009-03-19 21:55 ` Antonio Marques
2009-03-17 19:38 ` Antonio Marques
2009-03-17 22:03 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903180001.07723.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=andrey@cozybit.com \
--cc=froz@icix.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).