From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:47097 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753790AbZCRNPu (ORCPT ); Wed, 18 Mar 2009 09:15:50 -0400 Date: Wed, 18 Mar 2009 09:02:07 -0400 From: "John W. Linville" To: Ivo van Doorn Cc: linux-wireless@vger.kernel.org, Arnaud Patard , Gertjan van Wingerde , Dan Williams Subject: Re: [PATCH v2] Fix SLAB corruption during rmmod Message-ID: <20090318130207.GA3527@tuxdriver.com> (sfid-20090318_141552_828469_E1C2B487) References: <200903161925.41102.IvDoorn@gmail.com> <200903162024.27870.IvDoorn@gmail.com> <20090317211345.GI6737@tuxdriver.com> <200903172256.35485.IvDoorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <200903172256.35485.IvDoorn@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Mar 17, 2009 at 10:56:35PM +0100, Ivo van Doorn wrote: > On Tuesday 17 March 2009, John W. Linville wrote: > > On Mon, Mar 16, 2009 at 08:24:27PM +0100, Ivo van Doorn wrote: > > > At rmmod stage, the code path is the following one : > > >=20 > > > rt2x00lib_remove_dev > > > =A0 -> =A0rt2x00lib_uninitialize() > > > =A0 =A0 =A0 =A0 -> rt2x00rfkill_unregister() > > > =A0 =A0 =A0 =A0 =A0 =A0 =A0-> rfkill_unregister() > > > =A0 =A0 =A0 =A0 -> rt2x00rfkill_free() > > > =A0 =A0 =A0 =A0 =A0 =A0 =A0-> rfkill_free() > > >=20 > > > The problem is that rfkill_free should not be called after rfkill= _register > > > otherwise put_device(&rfkill->dev) will be called 2 times. This p= atch > > > fixes this by only calling rt2x00rfkill_free() when rt2x00rfkill_= register() > > > hasn't been called or has failed. > > >=20 > > > Signed-off-by: Gertjan van Wingerde > > > Tested-by: Arnaud Patard > > > Signed-off-by: Ivo van Doorn > > >=20 > > > --- > > > John, this patch is for 2.6.29 and only 2.6.29 since rfkill suppo= rt itself > > > was removed from later versions (replaced by input_polldev). > > > The patch is quite big to be merged in a late state of the releas= e cycle, > > > but since the SLAB corruption is a serious problem, I hope this c= an get in regardless. > >=20 > > Could you send me a version of this that applies on top of > > wireless-testing? >=20 > Actually no, the code isn't present at all in wireless-testing. > As I said, after 2.6.29 the entire rfkill structure is removed from r= t2x00 > and replaced by input_polldev. I guess I misunderstood. So just to be clear, no remnant or shadow of this patch should live-on to 2.6.30? It's just that the merge conflicts created by this patch were awful. With 2.6.29's release presumably close, maybe this is a candidate for the stable tree? John --=20 John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html