From: "John W. Linville" <linville@tuxdriver.com>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Mohamed Abbas <mohamed.abbas@intel.com>
Subject: Re: [PATCH 06/13] iwlcore: Fix scan problem, resource busy
Date: Thu, 19 Mar 2009 14:46:16 -0400 [thread overview]
Message-ID: <20090319184616.GC3587@tuxdriver.com> (raw)
In-Reply-To: <200903191712.01325.helmut.schaa@gmail.com>
On Thu, Mar 19, 2009 at 05:12:00PM +0100, Helmut Schaa wrote:
> Hi,
>=20
> Am Mittwoch, 18. M=E4rz 2009 schrieb Reinette Chatre:
> > From: Mohamed Abbas <mohamed.abbas@intel.com>
> >=20
> > when mac80211 issues scan request to lower driver, it always expect
> > a scan_complete notification from the driver, this driver make sure
> > we call scan_completed on all exit path in iwl_mac_hw_scan.
>=20
> It should suffice to return an error in iwl_mac_hw_scan (as done with=
out
> this patch). The problem was mac80211 not calling cfg80211 in case of=
a
> failure. [1] should fix that. Hence, this workaround in iwlwifi shoul=
d
> not be needed.
>=20
> Helmut
>=20
> [1] http://git.kernel.org/?p=3Dlinux/kernel/git/linville/wireless-tes=
ting.git;a=3Dcommit;h=3Da3fa954ddc4509721a691dd685c3d102cba0b58e
I think Helmut is right. I'm dropping patch 6/13.
John
--=20
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-19 19:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 4:51 [PATCH 0/13] iwlwifi driver updates 03/17/2009 Reinette Chatre
2009-03-18 4:51 ` [PATCH 01/13] iwlagn: use changed in mac_config Reinette Chatre
2009-03-18 4:51 ` [PATCH 02/13] iwl3945: use changed in iwl3945_mac_config Reinette Chatre
2009-03-18 4:51 ` [PATCH 03/13] iwlwifi: return 0 for AMPDU_TX/RX_STOP request if NIC is going down Reinette Chatre
2009-03-18 4:51 ` [PATCH 04/13] iwlagn: allow power level setting all the times Reinette Chatre
2009-03-18 4:51 ` [PATCH 05/13] iwlcore: dont commit power command if interface is not up Reinette Chatre
2009-03-18 4:51 ` [PATCH 06/13] iwlcore: Fix scan problem, resource busy Reinette Chatre
2009-03-18 4:51 ` [PATCH 07/13] iwlwifi: support 11h Reinette Chatre
2009-03-18 4:51 ` [PATCH 08/13] iwl3945: set TFD_QUEUE_MAX to correct value Reinette Chatre
2009-03-18 4:51 ` [PATCH 09/13] iwl3945: use iwl_cmd_queue_free Reinette Chatre
2009-03-18 4:51 ` [PATCH 10/13] iwl3945: fix checkpatch.pl errors Reinette Chatre
2009-03-18 4:51 ` [PATCH 11/13] iwl3945: control rate decrease Reinette Chatre
2009-03-18 4:51 ` [PATCH 12/13] iwlwifi: report error when detect failure during stop agg queue Reinette Chatre
2009-03-18 4:51 ` [PATCH 13/13] iwl3945: replace stations with stations_39 Reinette Chatre
2009-03-19 16:12 ` [PATCH 06/13] iwlcore: Fix scan problem, resource busy Helmut Schaa
2009-03-19 18:46 ` John W. Linville [this message]
2009-03-19 19:58 ` Abbas, Mohamed
2009-03-20 14:36 ` John W. Linville
2009-03-18 4:59 ` [PATCH 01/13 v2] iwlagn: use changed in mac_config reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319184616.GC3587@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=helmut.schaa@googlemail.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mohamed.abbas@intel.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).