* [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type
@ 2009-03-22 18:15 Michael Buesch
0 siblings, 0 replies; only message in thread
From: Michael Buesch @ 2009-03-22 18:15 UTC (permalink / raw)
To: linville; +Cc: Lorenzo Nava, bcm43xx-dev, linux-wireless
From: Lorenzo Nava <navalorenx@gmail.com>
This patch fixes the return type of b43_plcp_get_bitrate_idx_ofdm. If
the plcp contains an error, the function return value is 255 instead
of -1, and the packet was not dropped. This causes a warning in
__ieee80211_rx function because rate idx is out of range.
Cc: stable@kernel.org
Signed-off-by: Lorenzo Nava <navalorenx@gmail.com>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
---
John, please queue as a bugfix to the current kernel.
Index: wireless-testing/drivers/net/wireless/b43/xmit.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/xmit.c 2009-03-22 19:12:57.000000000 +0100
+++ wireless-testing/drivers/net/wireless/b43/xmit.c 2009-03-22 19:13:12.000000000 +0100
@@ -50,7 +50,7 @@ static int b43_plcp_get_bitrate_idx_cck(
}
/* Extract the bitrate index out of an OFDM PLCP header. */
-static u8 b43_plcp_get_bitrate_idx_ofdm(struct b43_plcp_hdr6 *plcp, bool aphy)
+static int b43_plcp_get_bitrate_idx_ofdm(struct b43_plcp_hdr6 *plcp, bool aphy)
{
int base = aphy ? 0 : 4;
--
Greetings, Michael.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-22 18:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-22 18:15 [PATCH] b43: fix b43_plcp_get_bitrate_idx_ofdm return type Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).