From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: linux-wireless@vger.kernel.org
Cc: Marek Vasut <marek.vasut@gmail.com>, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] Marvell CF8381
Date: Mon, 23 Mar 2009 13:27:18 +0100 [thread overview]
Message-ID: <200903231327.18890.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <200903220511.50229.marek.vasut@gmail.com>
> - priv->regioncode = le16_to_cpu(cmd.regioncode) & 0xFF;
> + priv->regioncode = (le16_to_cpu(cmd.regioncode) &
0xFF00) >> 8;
Hmm, the change that this breaks 8385 is quite high, maybe 100
percent.
It could simply be the case that your firmware returns the value
in a different order than mine. So we either need to test for the
firmware version or for the hardware before getting the value via
one or the other method.
Maybe it's worthwhile to create some hw_is_8381() function and
then do the things that need to be differently based on it's
return value?
The documentation for CMG_GET_HW_SPEC that I have says
RegionCode UINT16 Set to 0
so I see no indicator that we have two 8 bit values here. But
we've seen bugs in docs before :-)
next prev parent reply other threads:[~2009-03-23 12:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 0:27 [PATCH] Marvell CF8381 Marek Vasut
2009-03-22 4:11 ` Marek Vasut
2009-03-22 8:04 ` Johannes Berg
2009-03-22 13:01 ` Marek Vasut
2009-03-22 13:03 ` Johannes Berg
2009-03-23 12:27 ` Holger Schurig [this message]
2009-03-23 16:15 ` Dan Williams
2009-03-23 21:58 ` Marek Vasut
2009-03-23 23:08 ` Dan Williams
2009-03-23 23:42 ` Marek Vasut
2009-03-24 10:26 ` Dan Williams
2009-03-24 20:01 ` John W. Linville
2009-03-24 20:33 ` Marek Vasut
2009-03-23 12:13 ` Holger Schurig
2009-03-23 14:34 ` Marek Vasut
2009-03-23 15:57 ` [PATCH1/2] Fix return value handling Marek Vasut
2009-03-23 15:59 ` Marek Vasut
2009-03-23 16:11 ` Dan Williams
2009-03-23 15:59 ` [PATCH] Marvell CF8381 and CF8305 Marek Vasut
2009-03-23 16:00 ` Marek Vasut
2009-03-23 16:06 ` Holger Schurig
2009-03-23 17:09 ` Marek Vasut
2009-03-23 17:19 ` Dan Williams
2009-03-23 17:39 ` Marek Vasut
2009-03-23 16:58 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903231327.18890.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).