From: "John W. Linville" <linville@tuxdriver.com>
To: Christian Lamparter <chunkeey@web.de>
Cc: Michael Buesch <mb@bu3sch.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] p54: fix SoftLED compile dependencies
Date: Mon, 23 Mar 2009 10:14:49 -0400 [thread overview]
Message-ID: <20090323141449.GD3285@tuxdriver.com> (raw)
In-Reply-To: <200903210057.47067.chunkeey@web.de>
On Sat, Mar 21, 2009 at 12:57:46AM +0100, Christian Lamparter wrote:
> This patch fixes a compile problem when the MAC80211_LEDS
> triggers are enabled but not LED class itself.
> (which is sort of pointless, but anyway...)
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> ---
> mb, thank you for the tips!
>
> Randy Dunlap can you please give this patch a try?
>
> John, do you know where the patch form
> Geert Uytterhoeven <geert@linux-m68k.org> went?
> ---
> diff --git a/drivers/net/wireless/p54/Kconfig b/drivers/net/wireless/p54/Kconfig
> index 0e344ac..ee1aaca 100644
> --- a/drivers/net/wireless/p54/Kconfig
> +++ b/drivers/net/wireless/p54/Kconfig
> @@ -1,9 +1,10 @@
> config P54_COMMON
> tristate "Softmac Prism54 support"
> - depends on MAC80211 && WLAN_80211 && FW_LOADER && EXPERIMENTAL
> + depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
> + select FW_LOADER
> ---help---
> - This is common code for isl38xx based cards.
> - This module does nothing by itself - the USB/PCI frontends
> + This is common code for isl38xx/stlc45xx based modules.
> + This module does nothing by itself - the USB/PCI/SPI frontends
> also need to be enabled in order to support any devices.
>
> These devices require softmac firmware which can be found at
This hunk looks unrelated to the changelog as well...?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-03-23 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090319221024.5e2ad6e5.sfr@canb.auug.org.au>
2009-03-19 17:28 ` linux-next: Tree for March 19 (wireless/p54) Randy Dunlap
2009-03-19 17:50 ` Michael Buesch
2009-03-19 18:49 ` Randy Dunlap
2009-03-19 18:55 ` Michael Buesch
2009-03-20 23:57 ` [PATCH] p54: fix SoftLED compile dependencies Christian Lamparter
2009-03-21 6:36 ` Kalle Valo
2009-03-21 12:22 ` Christian Lamparter
2009-03-21 12:27 ` Kalle Valo
2009-03-21 15:26 ` Larry Finger
2009-03-23 14:13 ` John W. Linville
2009-03-23 14:37 ` [PATCH v2] " Christian Lamparter
2009-03-23 1:00 ` [PATCH] " Randy Dunlap
2009-03-23 14:14 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323141449.GD3285@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=chunkeey@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).