linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 0/8] mac80211 aggregation improvements
Date: Mon, 23 Mar 2009 17:28:34 +0100	[thread overview]
Message-ID: <20090323162834.154525349@sipsolutions.net> (raw)

Hi,
   
Here's my patch set for improving aggregation, it contains

 * mac80211: rewrite fragmentation
 * mac80211: fix A-MPDU queue assignment
 * mac80211: rework the pending packets code
 * mac80211: clean up __ieee80211_tx args   
 * mac80211: unify and fix TX aggregation start
 * mac80211: add skb length sanity checking
 * mac80211: fix aggregation to not require queue stop
 * mac80211/iwlwifi: move virtual A-MDPU queue bookkeeping to iwlwifi

The skb length sanity checking isn't strictly part of this series,
but it would help debug things like the zd1211 problem Jouni fixed
recently, and I wanted to do it after the third patch due to the  
amount of code changes in that.

The rest of the code changes fix/rework some things related to
pending frames and fragmentation (to be able to work with that
code for pending aggregation frames), clean up some aggregation
code and finally remove a lot of the code that was necessary for
trying to handle hardware aggregation queues in mac80211 -- the 
code for handling it in the driver is much simpler (because it  
can be less generic) too.

Despite adding new features, long comments and reworking things
the diffstat thus looks fairly good with not many new code lines
in total:

 drivers/net/wireless/ath9k/main.c           |    2
 drivers/net/wireless/iwlwifi/iwl-3945.c     |    2
 drivers/net/wireless/iwlwifi/iwl-4965.c     |    7
 drivers/net/wireless/iwlwifi/iwl-5000.c     |    7
 drivers/net/wireless/iwlwifi/iwl-core.c     |    3
 drivers/net/wireless/iwlwifi/iwl-dev.h      |    6
 drivers/net/wireless/iwlwifi/iwl-helpers.h  |   52 ++
 drivers/net/wireless/iwlwifi/iwl-tx.c       |    8   
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    2   
 drivers/net/wireless/mac80211_hwsim.c       |    1   
 include/net/mac80211.h                      |   22   
 net/mac80211/agg-tx.c                       |  243 ++++-----
 net/mac80211/ieee80211_i.h                  |   31 -
 net/mac80211/main.c                         |   13  
 net/mac80211/sta_info.c                     |   17  
 net/mac80211/sta_info.h                     |    4  
 net/mac80211/tx.c                           |  704 +++++++++++++++-------------
 net/mac80211/util.c                         |   97 +--
 net/mac80211/wep.c                          |   21    
 net/mac80211/wpa.c                          |   28 -  
 20 files changed, 656 insertions(+), 614 deletions(-) 


I've tested this with various Intel hardware, Sujith has also
tested with ath9k hardware (thanks!)

johannes


             reply	other threads:[~2009-03-23 16:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23 16:28 Johannes Berg [this message]
2009-03-23 16:28 ` [PATCH 1/8] mac80211: rewrite fragmentation Johannes Berg
2009-03-26  1:21   ` Luis R. Rodriguez
2009-03-26  1:26     ` Julian Calaby
2009-03-26  1:34       ` Luis R. Rodriguez
2009-03-26  1:34     ` Luis R. Rodriguez
2009-03-26  8:15     ` Johannes Berg
2009-03-23 16:28 ` [PATCH 2/8] mac80211: fix A-MPDU queue assignment Johannes Berg
2009-03-26  1:41   ` Luis R. Rodriguez
2009-03-23 16:28 ` [PATCH 3/8] mac80211: rework the pending packets code Johannes Berg
2009-03-27 22:22   ` Luis R. Rodriguez
2009-03-27 22:36     ` Johannes Berg
2009-03-23 16:28 ` [PATCH 4/8] mac80211: clean up __ieee80211_tx args Johannes Berg
2009-03-27 22:26   ` Luis R. Rodriguez
2009-03-23 16:28 ` [PATCH 5/8] mac80211: unify and fix TX aggregation start Johannes Berg
2009-03-28  2:27   ` Luis R. Rodriguez
2009-03-28  3:01     ` Luis R. Rodriguez
2009-03-28 17:28       ` Johannes Berg
2009-03-23 16:28 ` [PATCH 6/8] mac80211: add skb length sanity checking Johannes Berg
2009-03-28  2:40   ` Luis R. Rodriguez
2009-03-28  3:00     ` Luis R. Rodriguez
2009-03-28 17:29       ` Johannes Berg
2009-03-23 16:28 ` [PATCH 7/8] mac80211: fix aggregation to not require queue stop Johannes Berg
2009-03-28  4:55   ` Luis R. Rodriguez
2009-03-28 17:41     ` Johannes Berg
2009-03-28 19:18       ` Luis R. Rodriguez
2009-03-28 19:52         ` Johannes Berg
2009-03-28 20:26           ` Luis R. Rodriguez
2009-03-28 20:42             ` Johannes Berg
2009-03-28 21:06               ` Luis R. Rodriguez
2009-03-28 21:17                 ` Johannes Berg
2009-03-28 21:40                   ` Luis R. Rodriguez
2009-03-23 16:28 ` [PATCH 8/8] mac80211/iwlwifi: move virtual A-MDPU queue bookkeeping to iwlwifi Johannes Berg
2009-03-28  5:04   ` Luis R. Rodriguez
2009-03-24  8:28 ` [PATCH 0/8] mac80211 aggregation improvements Johannes Berg
2009-03-24 16:13   ` Luis R. Rodriguez
2009-03-24 19:48     ` John W. Linville
2009-03-24 20:24       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090323162834.154525349@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).