Re: [RFC] ath9k's regulatory domain code changes (for ar9170)

[Bob Copeland <me@bobcopeland.com>]

On Tue, Mar 24, 2009 at 04:52:09PM -0700, Luis R. Rodriguez wrote:
> Alright here's a quick concat of all these patches (also one small
> sparse fix on Christian's last patch). It also now throws ath5k, ath9k
> and ar9170 into ath/. We can rename the drivers after, was lazy to do
> that. Think its easier for review to separate that too.
> 
> http://bombadil.infradead.org/~mcgrof/patches/ath/ath-common-v3.patch.txt
> 
> Bob, where was that switch break error?

1st patch:

> +	switch (band) {
> +	case IEEE80211_BAND_2GHZ:
> +		ctl = ah->regulatory.regpair->reg_2ghz_ctl;
> +	case IEEE80211_BAND_5GHZ:
> +		ctl = ah->regulatory.regpair->reg_5ghz_ctl;
> +	default:
> +		ctl = NO_CTL;
> +	}
> +	return ctl;
> +}

I think I had it like the following and changed it -- actually with
the returns it's probably better...

switch (band) {
case XXX:
        return ah->...;
case YYY:
...
}

-- 
Bob Copeland %% www.bobcopeland.com