From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V2] mac80211: Fix bug in getting rx status for frames pending in reorder buffer
Date: Wed, 25 Mar 2009 18:01:54 +0530 [thread overview]
Message-ID: <20090325123154.GA29348@vasanth-laptop> (raw)
In-Reply-To: <1237983408.4320.159.camel@johannes.local>
On Wed, Mar 25, 2009 at 05:46:48PM +0530, Johannes Berg wrote:
> On Wed, 2009-03-25 at 17:34 +0530, Vasanthakumar Thiagarajan wrote:
> > Currently rx status for frames which are completed from reorder buffer
> > is taken from it's cb area which is not always right, cb is not holding
> > the rx status when driver uses mac80211's non-irq rx handler to pass it's
> > received frames. This results in dropping almost all frames from reorder
> > buffer when security is enabled by doing double decryption (first in hw,
> > second in sw because of wrong rx status). This patch copies rx status into
> > cb area before the frame is put into reorder buffer. After this patch,
> > there is a significant improvement in throughput with ath9k + WPA2(AES).
> >
> > Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
>
> I'll look at putting it there in the drivers right away for .31, this
> should probably get a Cc: stable@kernel.org too.
>
> johannes
>
I will resend the patch adding stable in Cc, thanks.
Vasanth
prev parent reply other threads:[~2009-03-25 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 12:04 [PATCH V2] mac80211: Fix bug in getting rx status for frames pending in reorder buffer Vasanthakumar Thiagarajan
2009-03-25 12:16 ` Johannes Berg
2009-03-25 12:31 ` Vasanthakumar Thiagarajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325123154.GA29348@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).