From: Max Filippov <jcmvbkbc@gmail.com>
To: Christian Lamparter <chunkeey@web.de>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 2/2 v2] p54spi: fix p54spi_upload_firmware
Date: Thu, 26 Mar 2009 04:15:26 +0300 [thread overview]
Message-ID: <200903260415.26646.jcmvbkbc@gmail.com> (raw)
In-Reply-To: <200903251345.01608.chunkeey@web.de>
> > > what do you think about the attached proposal?
> >
> > It looks generally better. But (fw + offset) wouldn't compile, because
> > fw is void*.
>
> ??? but it does compile?!
> CHECK drivers/net/wireless/p54/p54spi.c
> CC [M] drivers/net/wireless/p54/p54spi.o
> Building modules, stage 2.
> MODPOST 4 modules
> CC drivers/net/wireless/p54/p54spi.mod.o
> LD [M] drivers/net/wireless/p54/p54spi.ko
>
> But yes, I agree we better change void *fw to u8 *fw.
>
> BTW: does p54spi really work now?
Now firmware uploading code works fine. It even successfully uploads firmware
in small chunks.
--
Thanks.
-- Max
next prev parent reply other threads:[~2009-03-26 1:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 5:30 [PATCH 1/2] p54spi: mask value read from SPI_ADRS_DMA_WRITE_CTRL in p54spi_wait_bit Max Filippov
2009-03-25 5:30 ` [PATCH 2/2] p54spi: fix p54_upload_firmware Max Filippov
2009-03-25 11:21 ` Christian Lamparter
2009-03-25 12:00 ` Max Filippov
2009-03-25 12:45 ` [PATCH 2/2 v2] p54spi: fix p54spi_upload_firmware Christian Lamparter
2009-03-25 12:50 ` Max Filippov
2009-03-25 12:56 ` Johannes Berg
2009-03-26 2:26 ` Max Filippov
2009-03-25 13:42 ` Christian Lamparter
2009-03-25 14:34 ` Christian Lamparter
2009-03-26 6:22 ` p54spi - mesh mode summary Max Filippov
2009-03-26 8:12 ` Johannes Berg
2009-03-27 5:03 ` Max Filippov
2009-03-27 14:06 ` Christian Lamparter
2009-03-28 3:21 ` Max Filippov
2009-03-28 21:51 ` Christian Lamparter
2009-03-29 4:41 ` Max Filippov
2009-03-29 13:49 ` Christian Lamparter
2009-03-30 4:38 ` Max Filippov
2009-03-26 1:15 ` Max Filippov [this message]
2009-03-25 10:55 ` [PATCH 1/2] p54spi: mask value read from SPI_ADRS_DMA_WRITE_CTRL in p54spi_wait_bit Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903260415.26646.jcmvbkbc@gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).