From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
"Wey-Yi Guy" <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH 2/3] iwlwifi: remove STATUS_ALIVE checking from rf_kill
Date: Fri, 27 Mar 2009 07:18:17 +0100 [thread overview]
Message-ID: <200903270718.18593.helmut.schaa@gmail.com> (raw)
In-Reply-To: <1238087650-26993-3-git-send-email-reinette.chatre@intel.com>
Hi again,
Am Donnerstag, 26. M=E4rz 2009 schrieb Reinette Chatre:
> Remove STATUS_ALIVE checking when HW RF KILL disabled, the bit get
> clear in __iwl_down() function; the additional checking will fail and
> cause RF can not be turn back on.
Maybe just checking for is_open instead of STATUS_ALIVE will fix the is=
sue
too? I only had a quick look but it looks possible. AFAICS is_open indi=
cates
if the interface was taken up by mac80211. So if the interface is up bu=
t
STATUS_ALIVE is not set we want to restart the adapter after unkilling =
but
if the interface is still down (is_open=3D=3D0) we do not want to resta=
rt the
adapter. Furthermore, is_open is also set in case the interface was tak=
en
up but wireless was rfkilled.
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-27 6:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 17:14 [PATCH 0/3] iwlwifi driver updates 03/26/2009 Reinette Chatre
2009-03-26 17:14 ` [PATCH 1/3] iwlwifi: merge and better support of suspend/resume for iwlagn and iwl3945 Reinette Chatre
2009-03-26 17:14 ` [PATCH 2/3] iwlwifi: remove STATUS_ALIVE checking from rf_kill Reinette Chatre
2009-03-26 17:14 ` [PATCH 3/3] iwl3945: use iwl_mac_conf_tx Reinette Chatre
2009-03-26 17:50 ` [PATCH 2/3] iwlwifi: remove STATUS_ALIVE checking from rf_kill Helmut Schaa
2009-03-26 18:22 ` reinette chatre
2009-03-26 19:11 ` Helmut Schaa
2009-03-26 19:30 ` reinette chatre
2009-03-26 19:49 ` Helmut Schaa
2009-03-26 20:37 ` reinette chatre
2009-03-26 20:58 ` Helmut Schaa
2009-03-26 23:26 ` reinette chatre
2009-03-27 6:19 ` Helmut Schaa
2009-03-27 6:25 ` Helmut Schaa
2009-03-27 15:45 ` reinette chatre
2009-03-27 3:49 ` reinette chatre
2009-03-27 6:18 ` Helmut Schaa [this message]
2009-03-27 16:03 ` reinette chatre
2009-03-27 16:30 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903270718.18593.helmut.schaa@gmail.com \
--to=helmut.schaa@googlemail.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).