From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [RFC] rfkill/rfkill-input userspace API
Date: Sat, 28 Mar 2009 09:47:19 -0300 [thread overview]
Message-ID: <20090328124719.GF7439@khazad-dum.debian.net> (raw)
In-Reply-To: <20090328123645.GD7439@khazad-dum.debian.net>
Hi Matthew!
On Sat, 28 Mar 2009, Henrique de Moraes Holschuh wrote:
> On Fri, 27 Mar 2009, Matthew Garrett wrote:
> > On Fri, Mar 27, 2009 at 12:58:01PM -0300, Henrique de Moraes Holschuh wrote:
> > > Note: unless something is done to change the way X.org deals with
> > > input devices, rfkill-input is _useless_ in a large number of setups
> > > as far as input event handling goes, because it will never get any
> > > events after X.org evdev grabs the input device.
> >
> > X.org evdev doesn't grab the input device. We fixed that precisely
> > because it broke rfkill-input.
>
> Eh? What is that ioctl in the git version doing there, then? Did I
> get the code from the wrong branch or something?
Ok, more on this: the ioctl _is_ needed for privacy reasons, it wasn't
added there just for the kick of it AFAIK. Instead of just breaking
things the other way, can we configure evdev to sometimes do the grab,
and sometimes not, depending on a config option for that particular
device?
Keyboards should be grabbed. Platform driver event sources shouldn't
(most of the time, anyway). Adding flags to the input devices so that
the kernel can hint to userspace what should be done by default for a
given device is easy, and I offer to do the work. I already want to
add flags to tell the joystick and mouse emulation to keep clear of
hdaps, anyway...
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-03-28 12:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 15:58 [RFC] rfkill/rfkill-input userspace API Henrique de Moraes Holschuh
2009-03-27 15:58 ` [PATCH 1/4] rfkill: prepare to export global states to userspace Henrique de Moraes Holschuh
2009-03-27 15:58 ` [PATCH 2/4] rfkill: expose global switches through sysfs Henrique de Moraes Holschuh
2009-03-27 15:58 ` [PATCH 3/4] rfkill: expose global state to sysfs Henrique de Moraes Holschuh
2009-03-27 15:58 ` [PATCH 4/4] rfkill: export events for global state changes Henrique de Moraes Holschuh
2009-03-27 21:34 ` [RFC] rfkill/rfkill-input userspace API Johannes Berg
2009-03-28 12:37 ` Henrique de Moraes Holschuh
2009-03-27 22:11 ` Matthew Garrett
2009-03-28 12:36 ` Henrique de Moraes Holschuh
2009-03-28 12:44 ` Matthew Garrett
2009-03-28 12:47 ` Henrique de Moraes Holschuh [this message]
2009-03-28 12:53 ` Matthew Garrett
2009-03-28 14:48 ` Henrique de Moraes Holschuh
2009-03-28 15:02 ` Matthew Garrett
2009-03-28 15:14 ` Henrique de Moraes Holschuh
2009-03-28 15:22 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328124719.GF7439@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).