From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] rfkill: remove deprecated state constants
Date: Mon, 30 Mar 2009 10:42:54 -0700 [thread overview]
Message-ID: <200903301042.55352.inaky@linux.intel.com> (raw)
In-Reply-To: <1238405566.24972.16.camel@johannes.local>
On Monday 30 March 2009, Johannes Berg wrote:
> I only did superficial review, but these constants are stupid
> to have and without proper warnings nobody will review the
> code anyway, no amount of shouting will help.
>
> Also fix wimax to use correct states.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Let's push these changes through your tree; it's going to be
hell to coordinate otherwise, anyway.
--
Inaky
prev parent reply other threads:[~2009-03-30 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 13:12 [PATCH] rfkill: remove deprecated state constants Johannes Berg
2009-03-30 9:32 ` [PATCH v2] " Johannes Berg
2009-03-30 17:42 ` Inaky Perez-Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903301042.55352.inaky@linux.intel.com \
--to=inaky@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).