* [PATCH] b43legacy: Do not select HW_RANDOM
@ 2009-03-30 1:50 Larry Finger
2009-03-30 9:51 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2009-03-30 1:50 UTC (permalink / raw)
To: John W Linville, Michael Buesch; +Cc: bcm43xx-dev, linux-wireless
Auto-depend on HW_RANDOM, rather than "select"ing it.
This way the user has the choice to enable or disable HWRNG support.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John, please queue for 2.6.31.
Index: wireless-testing/drivers/net/wireless/b43legacy/Kconfig
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43legacy/Kconfig
+++ wireless-testing/drivers/net/wireless/b43legacy/Kconfig
@@ -3,7 +3,6 @@ config B43LEGACY
depends on SSB_POSSIBLE && MAC80211 && WLAN_80211 && HAS_DMA
select SSB
select FW_LOADER
- select HW_RANDOM
---help---
b43legacy is a driver for 802.11b devices from Broadcom (BCM4301 and
BCM4303) and early model 802.11g chips (BCM4306 Ver. 2) used in the
@@ -51,6 +50,13 @@ config B43LEGACY_RFKILL
depends on B43LEGACY && (RFKILL = y || RFKILL = B43LEGACY) && RFKILL_INPUT && (INPUT_POLLDEV = y || INPUT_POLLDEV = B43LEGACY)
default y
+# This config option automatically enables b43 HW-RNG support,
+# if the HW-RNG core is enabled.
+config B43legacy_HWRNG
+ bool
+ depends on B43legacy && (HW_RANDOM = y || HW_RANDOM = B43legacy)
+ default y
+
config B43LEGACY_DEBUG
bool "Broadcom 43xx-legacy debugging"
depends on B43LEGACY
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] b43legacy: Do not select HW_RANDOM
2009-03-30 1:50 [PATCH] b43legacy: Do not select HW_RANDOM Larry Finger
@ 2009-03-30 9:51 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2009-03-30 9:51 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, bcm43xx-dev, linux-wireless
On Monday 30 March 2009 03:50:47 Larry Finger wrote:
> Auto-depend on HW_RANDOM, rather than "select"ing it.
> This way the user has the choice to enable or disable HWRNG support.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John, please queue for 2.6.31.
>
>
>
> Index: wireless-testing/drivers/net/wireless/b43legacy/Kconfig
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43legacy/Kconfig
> +++ wireless-testing/drivers/net/wireless/b43legacy/Kconfig
> @@ -3,7 +3,6 @@ config B43LEGACY
> depends on SSB_POSSIBLE && MAC80211 && WLAN_80211 && HAS_DMA
> select SSB
> select FW_LOADER
> - select HW_RANDOM
> ---help---
> b43legacy is a driver for 802.11b devices from Broadcom (BCM4301 and
> BCM4303) and early model 802.11g chips (BCM4306 Ver. 2) used in the
> @@ -51,6 +50,13 @@ config B43LEGACY_RFKILL
> depends on B43LEGACY && (RFKILL = y || RFKILL = B43LEGACY) && RFKILL_INPUT && (INPUT_POLLDEV = y || INPUT_POLLDEV = B43LEGACY)
> default y
>
> +# This config option automatically enables b43 HW-RNG support,
> +# if the HW-RNG core is enabled.
> +config B43legacy_HWRNG
> + bool
> + depends on B43legacy && (HW_RANDOM = y || HW_RANDOM = B43legacy)
> + default y
> +
> config B43LEGACY_DEBUG
> bool "Broadcom 43xx-legacy debugging"
> depends on B43LEGACY
>
>
You also need to add #ifdefs to the code, don't you?
--
Greetings, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-30 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-30 1:50 [PATCH] b43legacy: Do not select HW_RANDOM Larry Finger
2009-03-30 9:51 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).