From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] b43legacy: Do not select HW_RANDOM
Date: Mon, 30 Mar 2009 22:53:25 +0200 [thread overview]
Message-ID: <200903302253.25710.mb@bu3sch.de> (raw)
In-Reply-To: <49d0e498.VVNw6/FIi1OemoLq%Larry.Finger@lwfinger.net>
On Monday 30 March 2009 17:26:16 Larry Finger wrote:
> Auto-depend on HW_RANDOM, rather than "select"ing it.
> This way the user has the choice to enable or disable HWRNG support.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John, please queue for 2.6.31.
>
>
>
> Index: wireless-testing/drivers/net/wireless/b43legacy/Kconfig
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43legacy/Kconfig
> +++ wireless-testing/drivers/net/wireless/b43legacy/Kconfig
> @@ -3,7 +3,6 @@ config B43LEGACY
> depends on SSB_POSSIBLE && MAC80211 && WLAN_80211 && HAS_DMA
> select SSB
> select FW_LOADER
> - select HW_RANDOM
> ---help---
> b43legacy is a driver for 802.11b devices from Broadcom (BCM4301 and
> BCM4303) and early model 802.11g chips (BCM4306 Ver. 2) used in the
> @@ -51,6 +50,13 @@ config B43LEGACY_RFKILL
> depends on B43LEGACY && (RFKILL = y || RFKILL = B43LEGACY) && RFKILL_INPUT && (INPUT_POLLDEV = y || INPUT_POLLDEV = B43LEGACY)
> default y
>
> +# This config option automatically enables b43 HW-RNG support,
> +# if the HW-RNG core is enabled.
> +config B43legacy_HWRNG
> + bool
> + depends on B43legacy && (HW_RANDOM = y || HW_RANDOM = B43legacy)
It seems like the symbol is B43LEGACY (uppercase).
Can you also change the new symbol to B43LEGACY_HWRNG, just for consistency with
all other symbols?
> + default y
> +
--
Greetings, Michael.
prev parent reply other threads:[~2009-03-30 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 15:26 [PATCH V2] b43legacy: Do not select HW_RANDOM Larry Finger
2009-03-30 20:53 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903302253.25710.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).