From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: wireless <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: b43 WARN_ON
Date: Mon, 6 Apr 2009 12:12:10 +0200 [thread overview]
Message-ID: <200904061212.10398.mb@bu3sch.de> (raw)
In-Reply-To: <49D97CF5.4040808@lwfinger.net>
On Monday 06 April 2009 05:54:29 Larry Finger wrote:
> Using the latest rfkill patches posted by Johannes, I am hitting the following
>
> if (WARN_ON(!wl->rfkill.registered))
> return -EINVAL;
I think we should simply remove the warning.
In the previous rfkill implementation I had a reason to _not_ warn here.
(It had one valid codepath where it was called. I don't remember the details...)
Anyway, please feel free to do a patch that removes the warning (but not the check).
>
> in b43_rfkill_soft_set() as follows:
>
> ------------[ cut here ]------------
> WARNING: at drivers/net/wireless/b43/rfkill.c:77 b43_rfkill_soft_set+0x38/0xb3
> [b43]()
> Hardware name: HP Pavilion dv2700 Notebook PC
> --snip--
> ---[ end trace a1ef19d1571fdb71 ]---
> b43 ssb0:0: firmware: requesting b43/ucode5.fw
> b43 ssb0:0: firmware: requesting b43/pcm5.fw
> b43 ssb0:0: firmware: requesting b43/b0g0initvals5.fw
> b43 ssb0:0: firmware: requesting b43/b0g0bsinitvals5.fw
> b43-phy0: Loading firmware version 478.104 (2008-07-01 00:50:23)
> b43-phy0 debug: Chip initialized
> b43-phy0 debug: 32-bit DMA initialized
> Registered led device: b43-phy0::tx
> Registered led device: b43-phy0::rx
> Registered led device: b43-phy0::radio
> b43-phy0 debug: Wireless interface started
> b43-phy0 debug: Adding Interface type 2
> b43-phy0: Radio turned on by software
>
> Larry
>
>
--
Greetings, Michael.
next prev parent reply other threads:[~2009-04-06 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 3:54 b43 WARN_ON Larry Finger
2009-04-06 10:12 ` Michael Buesch [this message]
2009-04-06 10:25 ` Johannes Berg
2009-04-06 11:55 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904061212.10398.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).