From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] cfg80211: Process regulatory max bandwidth checks for HT40
Date: Tue, 7 Apr 2009 09:10:33 -0700 [thread overview]
Message-ID: <20090407161033.GB5758@tesla> (raw)
In-Reply-To: <1239098925.22453.10.camel@johannes.local>
On Tue, Apr 07, 2009 at 03:08:45AM -0700, Johannes Berg wrote:
> On Mon, 2009-04-06 at 16:15 -0400, Luis R. Rodriguez wrote:
>
> > +static bool is_ht40_not_allowed(struct ieee80211_channel *chan)
>
> I think it would be nicer on the reader to remove the not?
>
> > +{
> > + if (!chan)
> > + return true;
> > + if (chan->flags & IEEE80211_CHAN_DISABLED)
> > + return true;
> > + /* This would happen when regulatory rules disallow HT40 completely */
> > + if (IEEE80211_CHAN_NO_HT40 == (chan->flags & (IEEE80211_CHAN_NO_HT40)))
> > + return true;
>
> How would that happen at this point?
Due to the regulatory freq rule.
> /me stops reading.
>
> Ok, whatever, I know I want to rewrite most of this anyway.
:)
next prev parent reply other threads:[~2009-04-07 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 20:15 [PATCH v2 0/5] wireless: listen to reg bw preferences Luis R. Rodriguez
2009-04-06 20:15 ` [PATCH v2 1/5] cfg80211: Process regulatory max bandwidth checks for HT40 Luis R. Rodriguez
2009-04-07 10:08 ` Johannes Berg
2009-04-07 16:10 ` Luis R. Rodriguez [this message]
2009-04-06 20:15 ` [PATCH v2 2/5] wireless: rename IEEE80211_CHAN_NO_FAT_* to HT40-/+ Luis R. Rodriguez
2009-04-06 20:15 ` [PATCH v2 3/5] mac80211: check if HT40+/- is allowed before sending assoc Luis R. Rodriguez
2009-04-07 10:11 ` Johannes Berg
2009-04-07 16:23 ` Luis R. Rodriguez
2009-04-07 19:09 ` Johannes Berg
2009-04-07 20:38 ` Luis R. Rodriguez
2009-04-07 20:41 ` Johannes Berg
2009-04-07 20:44 ` Luis R. Rodriguez
2009-04-07 20:53 ` Johannes Berg
2009-04-07 20:59 ` Luis R. Rodriguez
2009-04-06 20:15 ` [PATCH v2 4/5] cfg80211: check allowed channel type upon userspace requests Luis R. Rodriguez
2009-04-06 20:19 ` Luis R. Rodriguez
2009-04-06 20:15 ` [PATCH v2 5/5] mac80211: expose HT channel flags through debugfs Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090407161033.GB5758@tesla \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).