Re: mac80211: changing number of queues in ops->start

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 07 April 2009 21:46:29 Johannes Berg wrote:
> On Tue, 2009-04-07 at 21:40 +0200, Michael Buesch wrote:
> 
> > Ok I see. So you say it's OK to lower hw->queues after ieee80211_register.
> 
> Let's say it's acceptable ;)
> 
> > Should I reset hw->queues back to the value ieee80211_register was called with, before
> > I call unregister/free? Are there resources allocated by the number of queues?
> 
> There are resources allocated, notably the qdiscs etc. in
> alloc_ether_mq() or whatever it's called in register_hw(). But the
> networking core should keep track of those so it shouldn't matter what
> the value is. OTOH if it can switch back and forth the pending packets
> are done per queue... for example ieee80211_clear_tx_pending will be
> called at unregister times, so if it's possible to be up with 4 queues,
> and later be up with 1, you will want to unregister with 4.

Ok, sounds like a huge hack to me. :) I'll think about it.

-- 
Greetings, Michael.