From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <jouni.malinen@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Allow scan to be requested in AP mode
Date: Thu, 16 Apr 2009 19:00:56 +0300 [thread overview]
Message-ID: <20090416160056.GA7912@jm.kir.nu> (raw)
In-Reply-To: <1239897117.14169.8.camel@johannes.local>
On Thu, Apr 16, 2009 at 05:51:57PM +0200, Johannes Berg wrote:
> On Thu, 2009-04-16 at 18:44 +0300, Jouni Malinen wrote:
> > --- uml.orig/net/mac80211/cfg.c 2009-04-16 18:20:19.000000000 +0300
> > +++ uml/net/mac80211/cfg.c 2009-04-16 18:33:44.000000000 +0300
> > @@ -1167,7 +1167,8 @@ static int ieee80211_scan(struct wiphy *
> >
> > if (sdata->vif.type != NL80211_IFTYPE_STATION &&
> > sdata->vif.type != NL80211_IFTYPE_ADHOC &&
> > - sdata->vif.type != NL80211_IFTYPE_MESH_POINT)
> > + sdata->vif.type != NL80211_IFTYPE_MESH_POINT &&
> > + (sdata->vif.type != NL80211_IFTYPE_AP || sdata->u.ap.beacon))
> > return -EOPNOTSUPP;
>
> Should this return a different error code for AP then? Maybe -EBUSY for
> AP && beacon? Then again, EBUSY is already returned for "already
> scanning". hmm.
I thought about that for a moment, but did not come up with a good error
code.. ;-) EBUSY is not a good option here since that could be used by
applications to decide that they should try again (which would not help
here at all). If someone has a better one in mind, I would have no
problems changing this, but I don't see much problems with EOPNOTSUPP
either.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2009-04-16 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 15:44 [PATCH] mac80211: Allow scan to be requested in AP mode Jouni Malinen
2009-04-16 15:51 ` Johannes Berg
2009-04-16 16:00 ` Jouni Malinen [this message]
2009-04-16 16:03 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416160056.GA7912@jm.kir.nu \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox