From: Chris Wright <chrisw@sous-sol.org>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: stable@kernel.org, Arnaud Patard <apatard@mandriva.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Gertjan van Wingerde <gwingerde@gmail.com>
Subject: Re: [stable] [PATCH] rt2x00: Fix SLAB corruption during rmmod
Date: Fri, 17 Apr 2009 00:18:07 +0000 [thread overview]
Message-ID: <20090417001807.GA5020@hera.kernel.org> (raw)
In-Reply-To: <200904012118.12391.IvDoorn@gmail.com>
* Ivo van Doorn (ivdoorn@gmail.com) wrote:
> At rmmod stage, the code path is the following one :
>=20
> rt2x00lib_remove_dev
> =A0 -> =A0rt2x00lib_uninitialize()
> =A0 =A0 =A0 =A0 -> rt2x00rfkill_unregister()
> =A0 =A0 =A0 =A0 =A0 =A0 =A0-> rfkill_unregister()
> =A0 =A0 =A0 =A0 -> rt2x00rfkill_free()
> =A0 =A0 =A0 =A0 =A0 =A0 =A0-> rfkill_free()
>=20
> The problem is that rfkill_free should not be called after rfkill_reg=
ister
> otherwise put_device(&rfkill->dev) will be called 2 times. This patch
> fixes this by only calling rt2x00rfkill_free() when rt2x00rfkill_regi=
ster()
> hasn't been called or has failed.
>=20
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> Tested-by: Arnaud Patard <apatard@mandriva.com>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Who is the Author of this patch? The Signed-off-by order suggests is
Gertjan.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-17 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 19:18 [PATCH] rt2x00: Fix SLAB corruption during rmmod Ivo van Doorn
2009-04-17 0:18 ` Chris Wright [this message]
2009-04-17 3:13 ` [stable] " Gertjan van Wingerde
2009-04-17 6:56 ` Ivo Van Doorn
2009-04-17 20:26 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417001807.GA5020@hera.kernel.org \
--to=chrisw@sous-sol.org \
--cc=apatard@mandriva.com \
--cc=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).