From: Bob Copeland <me@bobcopeland.com>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com,
nbd@openwrt.org
Subject: Re: [PATCH 4/7] ath5k: Beaconing fixes
Date: Sun, 19 Apr 2009 10:40:48 -0400 [thread overview]
Message-ID: <20090419144048.GA866@hash.localnet> (raw)
In-Reply-To: <20090416002951.GD4138@makis>
On Thu, Apr 16, 2009 at 03:29:51AM +0300, Nick Kossifidis wrote:
> * Fix num_tx_pending function, we never read the register :P that's why we
> got all those "beacon queue 7 didn't stop messages".
>
> @@ -160,7 +160,8 @@ u32 ath5k_hw_num_tx_pending(struct ath5k_hw *ah, unsigned int queue)
> if (ah->ah_version == AR5K_AR5210)
> return false;
This was pre-existing code, but what's with ath5k_hw_num_tx_pending
returning true and false in some cases when it's supposed to return a
u32?
> - pending = (AR5K_QUEUE_STATUS(queue) & AR5K_QCU_STS_FRMPENDCNT);
> + pending = ath5k_hw_reg_read(ah, AR5K_QUEUE_STATUS(queue));
> + pending &= AR5K_QCU_STS_FRMPENDCNT;
Heh, oops.
--
Bob Copeland %% www.bobcopeland.com
prev parent reply other threads:[~2009-04-19 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 0:29 [PATCH 4/7] ath5k: Beaconing fixes Nick Kossifidis
2009-04-19 14:40 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090419144048.GA866@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).