From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Christian Lamparter <chunkeey@web.de>, linux-wireless@vger.kernel.org
Subject: Re: p54: power save disable patch twice
Date: Tue, 21 Apr 2009 08:58:20 -0400 [thread overview]
Message-ID: <20090421125820.GE17805@tuxdriver.com> (raw)
In-Reply-To: <87hc0iftzh.fsf@litku.valot.fi>
On Tue, Apr 21, 2009 at 08:36:50AM +0300, Kalle Valo wrote:
> Hi John,
>
> I noticed that latest wireless-testing had this patch twice:
>
> p54: deactivate broken powersave function
>
> This patch deactivates powersave in station mode.
>
> It does not work correctly yet, so the code does more harm than
> good.
>
> Reported-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> The first patch removes IEEE80211_HW_SUPPORTS_PS and
> IEEE80211_HW_PS_NULLFUNC_STACK, and the second patch removes only
> IEEE80211_HW_BEACON_FILTER. I assume that the idea was to remove
> everything in one go.
The original patch was against the master branch and did all of
them together. But I sent it to 2.6.30, which didn't ahve the
beacon filter part. So I applied it in two parts (more or less).
I probably should alter the commit message for the second part.
Thanks for the reminder!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-04-21 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 5:36 p54: power save disable patch twice Kalle Valo
2009-04-21 12:58 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421125820.GE17805@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=chunkeey@web.de \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).