From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Rami Rosen <roszenrami@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
David Miller <davem@davemloft.net>,
buytenh@marvell.com
Subject: Re: [PATCH ] mwl8: fix build warning.
Date: Tue, 21 Apr 2009 09:54:50 -0400 [thread overview]
Message-ID: <20090421135450.GI17805@tuxdriver.com> (raw)
In-Reply-To: <1240317120.17388.16.camel@johannes.local>
On Tue, Apr 21, 2009 at 02:32:00PM +0200, Johannes Berg wrote:
> On Tue, 2009-04-21 at 14:57 +0300, Rami Rosen wrote:
> > This patch fixes a build warning in mwl8.c.
> > (Marvell TOPDOG wireless driver)
> >
> > The warning it fixes is: "large integer implicitly truncated to unsigned type."
>
> > - rx_desc->rx_ctrl =
> > - cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
> > + rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
>
> Umm. This really needs to come with an explanation.
Yeah -- trading a warning for a silent error seems unreasonable. :-)
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2009-04-21 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 11:57 [PATCH ] mwl8: fix build warning Rami Rosen
2009-04-21 12:32 ` Johannes Berg
2009-04-21 13:54 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421135450.GI17805@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=buytenh@marvell.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=roszenrami@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).