* [PATCH] libertas: don't leak skb on receive error
@ 2009-04-07 19:41 Philip Rakity
2009-04-08 7:26 ` Holger Schurig
2009-04-08 14:23 ` Dan Williams
0 siblings, 2 replies; 4+ messages in thread
From: Philip Rakity @ 2009-04-07 19:41 UTC (permalink / raw)
To: libertas-dev; +Cc: linux-wireless, stable, prakity
Don't lead memory when receive errors
Signed-off-by: Philip Rakity <prakity@yahoo.com>
--- linux-2.6.29/drivers/net/wireless/libertas/rx.c.old 2009-04-01 13:19:26.000000000 -0700
+++ linux-2.6.29/drivers/net/wireless/libertas/rx.c 2009-04-01 13:19:57.000000000 -0700
@@ -170,6 +170,7 @@
lbs_deb_rx("rx err: frame received with bad length\n");
priv->stats.rx_length_errors++;
ret = 0;
+ dev_kfree_skb(skb);
goto done;
}
@@ -181,6 +182,7 @@
lbs_pr_alert("rxpd not ok\n");
priv->stats.rx_errors++;
ret = 0;
+ dev_kfree_skb(skb);
goto done;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libertas: don't leak skb on receive error
2009-04-07 19:41 [PATCH] libertas: don't leak skb on receive error Philip Rakity
@ 2009-04-08 7:26 ` Holger Schurig
2009-04-08 14:23 ` Dan Williams
1 sibling, 0 replies; 4+ messages in thread
From: Holger Schurig @ 2009-04-08 7:26 UTC (permalink / raw)
To: linux-wireless; +Cc: Philip Rakity, libertas-dev, stable
> Don't lead memory when receive errors
> Signed-off-by: Philip Rakity <prakity@yahoo.com>
Looks fine from my site (the libertas-if_cs-guy).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libertas: don't leak skb on receive error
2009-04-07 19:41 [PATCH] libertas: don't leak skb on receive error Philip Rakity
2009-04-08 7:26 ` Holger Schurig
@ 2009-04-08 14:23 ` Dan Williams
2009-04-21 17:39 ` [stable] " Chris Wright
1 sibling, 1 reply; 4+ messages in thread
From: Dan Williams @ 2009-04-08 14:23 UTC (permalink / raw)
To: Philip Rakity; +Cc: libertas-dev, linux-wireless, stable
On Tue, 2009-04-07 at 12:41 -0700, Philip Rakity wrote:
>
> Don't lead memory when receive errors
> Signed-off-by: Philip Rakity <prakity@yahoo.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> --- linux-2.6.29/drivers/net/wireless/libertas/rx.c.old 2009-04-01 13:19:26.000000000 -0700
> +++ linux-2.6.29/drivers/net/wireless/libertas/rx.c 2009-04-01 13:19:57.000000000 -0700
> @@ -170,6 +170,7 @@
> lbs_deb_rx("rx err: frame received with bad length\n");
> priv->stats.rx_length_errors++;
> ret = 0;
> + dev_kfree_skb(skb);
> goto done;
> }
>
> @@ -181,6 +182,7 @@
> lbs_pr_alert("rxpd not ok\n");
> priv->stats.rx_errors++;
> ret = 0;
> + dev_kfree_skb(skb);
> goto done;
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [stable] [PATCH] libertas: don't leak skb on receive error
2009-04-08 14:23 ` Dan Williams
@ 2009-04-21 17:39 ` Chris Wright
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wright @ 2009-04-21 17:39 UTC (permalink / raw)
To: Dan Williams; +Cc: Philip Rakity, linux-wireless, stable, libertas-dev
* Dan Williams (dcbw@redhat.com) wrote:
> On Tue, 2009-04-07 at 12:41 -0700, Philip Rakity wrote:
> >
> > Don't lead memory when receive errors
> > Signed-off-by: Philip Rakity <prakity@yahoo.com>
>
> Acked-by: Dan Williams <dcbw@redhat.com>
Doesn't look like this is upstream yet. Please send to
stable@kernel.org when it is.
thanks,
-chris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-04-21 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-07 19:41 [PATCH] libertas: don't leak skb on receive error Philip Rakity
2009-04-08 7:26 ` Holger Schurig
2009-04-08 14:23 ` Dan Williams
2009-04-21 17:39 ` [stable] " Chris Wright
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).