[PATCH ] [RESEND] mwl8: fix build warning.

[PATCH ] [RESEND] mwl8: fix build warning.

[Rami Rosen]

This patch fixes a build warning in mwl8.c.
(Marvell TOPDOG wireless driver)

The warning it fixes is: "large integer implicitly truncated to unsigned type."

The rx_ctrl member of the mwl8k_rx_desc struct is 8 bit (__u8 ), whereas trying
to assign it a 32 bit value (which is returned from  cpu_to_le32())
causes the compiler to issue
a truncation warning.


Signed-off-by: Rami Rosen <ramirose@gmail.com>

--
(wireless-next)

diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 57a0268..8bc016c 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -893,8 +893,7 @@ static int mwl8k_rxq_init(struct ieee80211_hw *hw,
int index)
               rx_desc->next_rx_desc_phys_addr =
                       cpu_to_le32(rxq->rx_desc_dma
                                               + nexti * sizeof(*rx_desc));
-               rx_desc->rx_ctrl =
-                       cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
+               rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
       }

       return 0;

Re: [PATCH ] [RESEND] mwl8: fix build warning.

[John W. Linville]

On Tue, Apr 21, 2009 at 04:22:01PM +0300, Rami Rosen wrote:
> This patch fixes a build warning in mwl8.c.
> (Marvell TOPDOG wireless driver)
> 
> The warning it fixes is: "large integer implicitly truncated to unsigned type."
> 
> The rx_ctrl member of the mwl8k_rx_desc struct is 8 bit (__u8 ), whereas trying
> to assign it a 32 bit value (which is returned from  cpu_to_le32())
> causes the compiler to issue
> a truncation warning.
> 
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Oh, duh...I should have looked for the obvious answer... :-)

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH ] [RESEND] mwl8: fix build warning.

[John W. Linville]

On Tue, Apr 21, 2009 at 04:22:01PM +0300, Rami Rosen wrote:
> This patch fixes a build warning in mwl8.c.
> (Marvell TOPDOG wireless driver)
> 
> The warning it fixes is: "large integer implicitly truncated to unsigned type."
> 
> The rx_ctrl member of the mwl8k_rx_desc struct is 8 bit (__u8 ), whereas trying
> to assign it a 32 bit value (which is returned from  cpu_to_le32())
> causes the compiler to issue
> a truncation warning.
> 
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
> --
> (wireless-next)
> 
> diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
> index 57a0268..8bc016c 100644
> --- a/drivers/net/wireless/mwl8k.c
> +++ b/drivers/net/wireless/mwl8k.c
> @@ -893,8 +893,7 @@ static int mwl8k_rxq_init(struct ieee80211_hw *hw,
> int index)
>                rx_desc->next_rx_desc_phys_addr =
>                        cpu_to_le32(rxq->rx_desc_dma
>                                                + nexti * sizeof(*rx_desc));
> -               rx_desc->rx_ctrl =
> -                       cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
> +               rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
>        }
> 
>        return 0;

This patch is whitspace damaged.  I manually recreated it since it
is so simple, but please do be more careful with future patches.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.