* [PATCH ] [RESEND] mwl8: fix build warning.
@ 2009-04-21 13:22 Rami Rosen
2009-04-21 13:57 ` John W. Linville
2009-04-21 20:32 ` John W. Linville
0 siblings, 2 replies; 3+ messages in thread
From: Rami Rosen @ 2009-04-21 13:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, David Miller, Johannes Berg, buytenh
This patch fixes a build warning in mwl8.c.
(Marvell TOPDOG wireless driver)
The warning it fixes is: "large integer implicitly truncated to unsigned type."
The rx_ctrl member of the mwl8k_rx_desc struct is 8 bit (__u8 ), whereas trying
to assign it a 32 bit value (which is returned from cpu_to_le32())
causes the compiler to issue
a truncation warning.
Signed-off-by: Rami Rosen <ramirose@gmail.com>
--
(wireless-next)
diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
index 57a0268..8bc016c 100644
--- a/drivers/net/wireless/mwl8k.c
+++ b/drivers/net/wireless/mwl8k.c
@@ -893,8 +893,7 @@ static int mwl8k_rxq_init(struct ieee80211_hw *hw,
int index)
rx_desc->next_rx_desc_phys_addr =
cpu_to_le32(rxq->rx_desc_dma
+ nexti * sizeof(*rx_desc));
- rx_desc->rx_ctrl =
- cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
+ rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
}
return 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH ] [RESEND] mwl8: fix build warning.
2009-04-21 13:22 [PATCH ] [RESEND] mwl8: fix build warning Rami Rosen
@ 2009-04-21 13:57 ` John W. Linville
2009-04-21 20:32 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2009-04-21 13:57 UTC (permalink / raw)
To: Rami Rosen; +Cc: linux-wireless, David Miller, Johannes Berg, buytenh
On Tue, Apr 21, 2009 at 04:22:01PM +0300, Rami Rosen wrote:
> This patch fixes a build warning in mwl8.c.
> (Marvell TOPDOG wireless driver)
>
> The warning it fixes is: "large integer implicitly truncated to unsigned type."
>
> The rx_ctrl member of the mwl8k_rx_desc struct is 8 bit (__u8 ), whereas trying
> to assign it a 32 bit value (which is returned from cpu_to_le32())
> causes the compiler to issue
> a truncation warning.
>
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Oh, duh...I should have looked for the obvious answer... :-)
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ] [RESEND] mwl8: fix build warning.
2009-04-21 13:22 [PATCH ] [RESEND] mwl8: fix build warning Rami Rosen
2009-04-21 13:57 ` John W. Linville
@ 2009-04-21 20:32 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2009-04-21 20:32 UTC (permalink / raw)
To: Rami Rosen; +Cc: linux-wireless, David Miller, Johannes Berg, buytenh
On Tue, Apr 21, 2009 at 04:22:01PM +0300, Rami Rosen wrote:
> This patch fixes a build warning in mwl8.c.
> (Marvell TOPDOG wireless driver)
>
> The warning it fixes is: "large integer implicitly truncated to unsigned type."
>
> The rx_ctrl member of the mwl8k_rx_desc struct is 8 bit (__u8 ), whereas trying
> to assign it a 32 bit value (which is returned from cpu_to_le32())
> causes the compiler to issue
> a truncation warning.
>
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> --
> (wireless-next)
>
> diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
> index 57a0268..8bc016c 100644
> --- a/drivers/net/wireless/mwl8k.c
> +++ b/drivers/net/wireless/mwl8k.c
> @@ -893,8 +893,7 @@ static int mwl8k_rxq_init(struct ieee80211_hw *hw,
> int index)
> rx_desc->next_rx_desc_phys_addr =
> cpu_to_le32(rxq->rx_desc_dma
> + nexti * sizeof(*rx_desc));
> - rx_desc->rx_ctrl =
> - cpu_to_le32(MWL8K_RX_CTRL_OWNED_BY_HOST);
> + rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
> }
>
> return 0;
This patch is whitspace damaged. I manually recreated it since it
is so simple, but please do be more careful with future patches.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-21 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-21 13:22 [PATCH ] [RESEND] mwl8: fix build warning Rami Rosen
2009-04-21 13:57 ` John W. Linville
2009-04-21 20:32 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).