From: "John W. Linville" <linville@tuxdriver.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 3/5] rt2x00: Fix the interval for rfkill and link_tuner.
Date: Tue, 28 Apr 2009 14:57:10 -0400 [thread overview]
Message-ID: <20090428185709.GA3321@tuxdriver.com> (raw)
In-Reply-To: <200904261609.11447.IvDoorn@gmail.com>
On Sun, Apr 26, 2009 at 04:09:11PM +0200, Ivo van Doorn wrote:
> From: Alban Browaeys <prahal@yahoo.com>
>
> extra parenthesis made the value an argument and the value of the
> define empty. This was triggering those very fast.
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
???
If that were so, wouldn't that have caused compile-time errors?
John
> ---
> drivers/net/wireless/rt2x00/rt2x00lib.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00lib.h b/drivers/net/wireless/rt2x00/rt2x00lib.h
> index aa284e4..747178c 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00lib.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00lib.h
> @@ -32,8 +32,8 @@
> * Interval defines
> * Both the link tuner as the rfkill will be called once per second.
> */
> -#define LINK_TUNE_INTERVAL ( round_jiffies_relative(HZ) )
> -#define RFKILL_POLL_INTERVAL ( 1000 )
> +#define LINK_TUNE_INTERVAL round_jiffies_relative(HZ)
> +#define RFKILL_POLL_INTERVAL 1000
>
> /*
> * rt2x00_rate: Per rate device information
> --
> 1.6.2.3
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-04-28 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 14:08 [PATCH 1/5] rt2x00: Move iv_len into tx descriptor data Ivo van Doorn
2009-04-26 14:08 ` [PATCH 2/5] rt2x00: Add support for L2 padding during TX/RX Ivo van Doorn
2009-04-26 14:09 ` [PATCH 3/5] rt2x00: Fix the interval for rfkill and link_tuner Ivo van Doorn
2009-04-26 14:09 ` [PATCH 4/5] rt2x00: Implement support for 802.11n Ivo van Doorn
2009-04-26 14:11 ` [PATCH 5/5] rt2x00: Implement support for rt2800usb Ivo van Doorn
2009-04-28 18:57 ` John W. Linville [this message]
2009-04-28 20:18 ` [PATCH 3/5] rt2x00: Fix the interval for rfkill and link_tuner Ivo Van Doorn
2009-04-29 19:43 ` John W. Linville
2009-04-29 19:57 ` Ivo van Doorn
2009-04-29 22:09 ` Alban browaeys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428185709.GA3321@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).