* linux-next: driver-core tree build warning
@ 2009-05-01 5:21 Stephen Rothwell
2009-05-01 5:47 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2009-05-01 5:21 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, John W. Linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]
Hi Greg,
Today's linux-next build (x86_64 allmodconfig) produced these warnings:
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
remove driver_data direct access of struct device").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: driver-core tree build warning
2009-05-01 5:21 linux-next: driver-core tree build warning Stephen Rothwell
@ 2009-05-01 5:47 ` Greg KH
2009-05-01 6:11 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2009-05-01 5:47 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, John W. Linville, linux-wireless
On Fri, May 01, 2009 at 03:21:44PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
> drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
> drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
> drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
> drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
>
> Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
> remove driver_data direct access of struct device").
Ah crap, my bad. I'll go fix this up, it passed my build tests, I
wonder why this isn't an error, I missed the warning.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: driver-core tree build warning
2009-05-01 5:47 ` Greg KH
@ 2009-05-01 6:11 ` Greg KH
2009-05-01 7:11 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2009-05-01 6:11 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, John W. Linville, linux-wireless
On Thu, Apr 30, 2009 at 10:47:27PM -0700, Greg KH wrote:
> On Fri, May 01, 2009 at 03:21:44PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> >
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_cfg':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3491: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_status':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3500: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_capability':
> > drivers/net/wireless/ipw2x00/ipw2100.c:3509: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> > drivers/net/wireless/ipw2x00/ipw2100.c: In function 'show_rf_kill':
> > drivers/net/wireless/ipw2x00/ipw2100.c:4227: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> > include/linux/device.h:457: note: expected 'const struct device *' but argument is of type 'struct device **'
> >
> > Introduced by commit 73119f5e60e3b16577e99e2f035039bed0d2dcca ("Wireless:
> > remove driver_data direct access of struct device").
>
> Ah crap, my bad. I'll go fix this up, it passed my build tests, I
> wonder why this isn't an error, I missed the warning.
I've sent an updated version of the patch that fixes this to John and
the wireless mailing list and updated my tree as well.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: driver-core tree build warning
2009-05-01 6:11 ` Greg KH
@ 2009-05-01 7:11 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2009-05-01 7:11 UTC (permalink / raw)
To: Greg KH; +Cc: linux-next, John W. Linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
Hi Greg,
On Thu, 30 Apr 2009 23:11:18 -0700 Greg KH <greg@kroah.com> wrote:
>
> On Thu, Apr 30, 2009 at 10:47:27PM -0700, Greg KH wrote:
> > Ah crap, my bad. I'll go fix this up, it passed my build tests, I
> > wonder why this isn't an error, I missed the warning.
I assume it is actually valid C (just not good C :-)).
> I've sent an updated version of the patch that fixes this to John and
> the wireless mailing list and updated my tree as well.
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-05-01 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-01 5:21 linux-next: driver-core tree build warning Stephen Rothwell
2009-05-01 5:47 ` Greg KH
2009-05-01 6:11 ` Greg KH
2009-05-01 7:11 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).