From: Jouni Malinen <jouni.malinen@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Jouni Malinen <jouni.malinen@atheros.com>
Subject: [PATCH 1/4] nl80211: Validate MFP flag type when parsing STA flags
Date: Mon, 11 May 2009 21:57:55 +0300 [thread overview]
Message-ID: <20090511185842.074874801@atheros.com> (raw)
In-Reply-To: 20090511185754.653711567@atheros.com
NL80211_STA_FLAG_MFP was forgotten from sta_flags_policy. The previous
version added the flag due to the loop used in parse_station_flags,
but the proper behavior would be to allow nla_parse_nested() to go
through the policy for all flags.
Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)
--- uml.orig/net/wireless/nl80211.c 2009-05-11 21:39:23.000000000 +0300
+++ uml/net/wireless/nl80211.c 2009-05-11 21:39:23.000000000 +0300
@@ -1331,6 +1331,7 @@ static const struct nla_policy sta_flags
[NL80211_STA_FLAG_AUTHORIZED] = { .type = NLA_FLAG },
[NL80211_STA_FLAG_SHORT_PREAMBLE] = { .type = NLA_FLAG },
[NL80211_STA_FLAG_WME] = { .type = NLA_FLAG },
+ [NL80211_STA_FLAG_MFP] = { .type = NLA_FLAG },
};
static int parse_station_flags(struct nlattr *nla, u32 *staflags)
--
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2009-05-11 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 18:57 [PATCH 0/4] nl80211/mac80211: Fix station mode key setup issues Jouni Malinen
2009-05-11 18:57 ` Jouni Malinen [this message]
2009-05-11 18:57 ` [PATCH 2/4] nl80211: improve station flags handling Jouni Malinen
2009-05-11 18:57 ` [PATCH 3/4] nl80211: Add IEEE 802.1X PAE control for station mode Jouni Malinen
2009-05-11 18:57 ` [PATCH 4/4] nl80211: Add RSC configuration for new keys Jouni Malinen
2009-05-13 23:38 ` Johannes Berg
2009-05-11 19:26 ` [PATCH 0/4] nl80211/mac80211: Fix station mode key setup issues Johannes Berg
2009-05-11 19:38 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090511185842.074874801@atheros.com \
--to=jouni.malinen@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).