linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@web.de>
To: linux-wireless@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH 6/6] ar9170: stop data queues on channel switch
Date: Tue, 12 May 2009 01:09:09 +0200	[thread overview]
Message-ID: <200905120109.09906.chunkeey@web.de> (raw)

Currently we didn't check if there are still pending frames

Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff --git a/drivers/net/wireless/ath/ar9170/main.c b/drivers/net/wireless/ath/ar9170/main.c
index a66aa7d..8c8f45b 100644
--- a/drivers/net/wireless/ath/ar9170/main.c
+++ b/drivers/net/wireless/ath/ar9170/main.c
@@ -1299,6 +1299,37 @@ static void ar9170_op_remove_interface(struct ieee80211_hw *hw,
 	mutex_unlock(&ar->mutex);
 }
 
+static int ar9170_stop_and_flush_queues(struct ar9170 *ar)
+{
+	int err;
+
+	ieee80211_stop_queues(ar->hw);
+
+	err = ar->flush(ar);
+	if (err) {
+		printk(KERN_ERR "%s: device is not responding (%d)!\n",
+		       wiphy_name(ar->hw->wiphy), err);
+
+		/* FIXME: purge tx_status queues and reset */
+	}
+
+	return err;
+}
+
+static void ar9170_wake_queues(struct ar9170 *ar)
+{
+	unsigned long flags;
+	unsigned int i;
+
+	spin_lock_irqsave(&ar->tx_stats_lock, flags);
+	for (i = 0; i < __AR9170_NUM_TXQ; i++) {
+		if ((ar->tx_stats[i].len < ar->tx_stats[i].limit) &&
+		    (ieee80211_queue_stopped(ar->hw, i)))
+			ieee80211_wake_queue(ar->hw, i);
+	}
+	spin_unlock_irqrestore(&ar->tx_stats_lock, flags);
+}
+
 static int ar9170_op_config(struct ieee80211_hw *hw, u32 changed)
 {
 	struct ar9170 *ar = hw->priv;
@@ -1344,6 +1375,9 @@ static int ar9170_op_config(struct ieee80211_hw *hw, u32 changed)
 	}
 
 	if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
+		err = ar9170_stop_and_flush_queues(ar);
+		if (err)
+			goto out;
 
 		/* adjust slot time for 5 GHz */
 		err = ar9170_set_slot_time(ar);
@@ -1359,10 +1393,12 @@ static int ar9170_op_config(struct ieee80211_hw *hw, u32 changed)
 				nl80211_to_ar9170(hw->conf.channel_type));
 		if (err)
 			goto out;
+
 	}
 
 out:
 	mutex_unlock(&ar->mutex);
+	ar9170_wake_queues(ar);
 	return err;
 }
 

             reply	other threads:[~2009-05-12  0:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 23:09 Christian Lamparter [this message]
2009-05-12  6:39 ` [PATCH 6/6] ar9170: stop data queues on channel switch Johannes Berg
2009-05-12 15:15   ` Christian Lamparter
2009-05-12 16:45     ` Johannes Berg
2009-05-12 15:29   ` Bob Copeland
2009-05-12 15:30     ` Johannes Berg
2009-05-12 15:56       ` Bob Copeland
2009-05-12 16:56         ` Christian Lamparter
2009-05-12 17:51           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905120109.09906.chunkeey@web.de \
    --to=chunkeey@web.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).