From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
Stefano Brivio <stefano.brivio@polimi.it>,
wireless <linux-wireless@vger.kernel.org>,
Broadcom Linux <bcm43xx-dev@lists.berlios.de>
Subject: Re: [PATCH 1/2] b43legacy: Remove unnecessary MMIO in interrupt hotpath
Date: Fri, 15 May 2009 01:54:40 +0200 [thread overview]
Message-ID: <200905150154.40819.mb@bu3sch.de> (raw)
In-Reply-To: <4A0CA755.8000802@lwfinger.net>
On Friday 15 May 2009 01:20:53 Larry Finger wrote:
> dev->dma_reason[0] = b43legacy_read32(dev,
> B43legacy_MMIO_DMA0_REASON)
> & 0x0001DC00;
> - dev->dma_reason[1] = b43legacy_read32(dev,
> - B43legacy_MMIO_DMA1_REASON)
> - & 0x0000DC00;
> - dev->dma_reason[2] = b43legacy_read32(dev,
> - B43legacy_MMIO_DMA2_REASON)
> - & 0x0000DC00;
> - dev->dma_reason[3] = b43legacy_read32(dev,
> - B43legacy_MMIO_DMA3_REASON)
> - & 0x0001DC00;
> - dev->dma_reason[4] = b43legacy_read32(dev,
> - B43legacy_MMIO_DMA4_REASON)
> - & 0x0000DC00;
> - dev->dma_reason[5] = b43legacy_read32(dev,
> - B43legacy_MMIO_DMA5_REASON)
> - & 0x0000DC00;
> +/* Unused rings.
> + * dev->dma_reason[1] = b43legacy_read32(dev,
> + * B43legacy_MMIO_DMA1_REASON)
> + * & 0x0000DC00;
> + * dev->dma_reason[2] = b43legacy_read32(dev,
> + * B43legacy_MMIO_DMA2_REASON)
> + * & 0x0000DC00;
> + * dev->dma_reason[3] = b43legacy_read32(dev,
> + * B43legacy_MMIO_DMA3_REASON)
> + * & 0x0001DC00;
> + * dev->dma_reason[4] = b43legacy_read32(dev,
> + * B43legacy_MMIO_DMA4_REASON)
> + * & 0x0000DC00;
> + * dev->dma_reason[5] = b43legacy_read32(dev,
> + * B43legacy_MMIO_DMA5_REASON)
> + * & 0x0000DC00;
> + */
This is not correct. Ring1 is used for transmission.
With this patch applied, you won't receive error notification interrupts
for the TX ring anymore.
And ring3 is used for transmission status reporting on old devices.
This patch breaks it for these devices.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-05-14 23:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 23:20 [PATCH 1/2] b43legacy: Remove unnecessary MMIO in interrupt hotpath Larry Finger
2009-05-14 23:54 ` Michael Buesch [this message]
2009-05-15 20:39 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905150154.40819.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).