Re: [RFT v9] rfkill: rewrite

Johannes Berg
2009-05-14T10:01:24Z

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On Thu, 2009-05-14 at 10:58 +0100, Alan Jenkins wrote:

> > Very good, thank you! That means I don't have to fix anything in
> > rfkill :)
>
> Yep, seems so. I'm now able to test the rfkill functionality and it
> all seems fine. The new resume code successfully fixes the
> hibernation corner-case I brought up. So I'm happy and you can add my
>
> Tested-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

Thanks.

> You should probably drop my Signed-off-by though, seeing as it no
> longer includes the eeepc-laptop resume handler I wrote.

Ok.

> Oh, and don't forget the "whitespace error" flagged by git-apply.
> scripts/checkpatch.pl will flag it up as well. Checkpatch also says
> you shouldn't initialize "rfkill_no = 0" because it's a static (and
> therefore will default to zero in the absence of an initializer).

Good plan, I'll fix those, thanks.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]